Skip to content

[MPS] Add nearest_3d forward and backward #156090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malfet wants to merge 12 commits into from
Closed

[MPS] Add nearest_3d forward and backward #156090

malfet wants to merge 12 commits into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Jun 16, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Introduce generalizable UpsampleParams structure in UpSample.h, which could be shared between CPU and MPS
Delete upsample_nearest3d MPS fallback and replace it with proper shader

@malfet
Update
64ee133 
[ghstack-poisoned]
@malfet malfet requested a review from kulinseth as a code owner June 16, 2025 13:47
@malfet malfet mentioned this pull request Jun 16, 2025
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156090

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f586dce with merge base 32c1611 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category release notes: inductor (aoti) labels Jun 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2025

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.

Caused by:

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2025

Attention! PyTorch one of the C-stable API file was changed

You MUST NOT change existing function declarations in this, as this header defines a stable C ABI. If you need to change the signature for a function, introduce a new v2 version of the function and modify code generation to target the new version of the function.

Caused by:

@malfet
Update
0cd73ad 
[ghstack-poisoned]
@malfet
Update
bb4dad4 
[ghstack-poisoned]
malfet added a commit that referenced this pull request Jun 16, 2025
@malfet
[Wip] Add trilineard_3d and nearest_3d
ec3286b 
ghstack-source-id: 3736ec3
Pull Request resolved: #156090
@malfet
Update
fbee092 
[ghstack-poisoned]
@malfet malfet mentioned this pull request Jun 16, 2025
Closed
@malfet
Update
b09d28d 
[ghstack-poisoned]
malfet added a commit that referenced this pull request Jun 16, 2025
@malfet
[Wip] Add trilineard_3d and nearest_3d
ab533d6 
ghstack-source-id: 9c105dd
Pull Request resolved: #156090
@malfet
Update
df61e6c 
[ghstack-poisoned]
@malfet
Update
df5d011 
[ghstack-poisoned]
malfet added a commit that referenced this pull request Jun 17, 2025
@malfet
[Wip] Add trilineard_3d and nearest_3d
4cb2de8 
ghstack-source-id: fab8812
Pull Request resolved: #156090
@malfet
Update
215e342 
[ghstack-poisoned]
@malfet malfet requested a review from mruberry as a code owner June 17, 2025 19:01
@malfet
Update
e0baa85 
[ghstack-poisoned]
@malfet malfet mentioned this pull request Jun 18, 2025
Closed
@malfet malfet changed the title [Wip] Add trilineard_3d and nearest_3d [MPS] Add nearest_3d forward and backward Jun 18, 2025
@malfet
Update
b405636 
[ghstack-poisoned]
@malfet
Update
22425c3 
[ghstack-poisoned]
@malfet malfet requested a review from dcci June 18, 2025 00:36
@malfet
Update
f586dce 
[ghstack-poisoned]
@malfet malfet mentioned this pull request Jun 18, 2025
Closed
@malfet malfet added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 18, 2025
@malfet
Copy link
Contributor Author

malfet commented Jun 18, 2025

@pytorchbot merge -f "All is green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 18, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@sawaraken sawaraken bot mentioned this pull request Jun 18, 2025
Open
pytorchmergebot pushed a commit that referenced this pull request Jun 18, 2025
@malfet @pytorchmergebot
[MPS] Implement upsample_trilinear as Metal shader (#156263)
36f7a02 
But only forward for now
Pull Request resolved: #156263
Approved by: https://github.com/dcci
ghstack dependencies: #156256, #156090
@malfet malfet mentioned this pull request Jul 3, 2025
Open
@github-actions github-actions bot deleted the gh/malfet/408/head branch July 19, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kulinseth kulinseth kulinseth approved these changes

@dcci dcci dcci approved these changes

@mruberry mruberry Awaiting requested review from mruberry

Assignees

No one assigned

Labels

ciflow/inductor ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: mps Release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@malfet @pytorchmergebot @kulinseth @dcci