Handling overflow for long int overflow for the product of kernel_hei… #155989
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155989
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d12e636 with merge base 0815091 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "topic: not user facing" |
malfet
left a comment
malfet
left a comment
There was a problem hiding this comment.
Overall looks good to me, but please add a test
|
hi @malfet I have made the changes and added test. Can you please check the changes made. Thanks!! |
malfet
left a comment
malfet
left a comment
There was a problem hiding this comment.
LGTM, not sure if one should replace const auto rc = foo(); if (!foo) { TORCH_CHECK(false,"BAR"); with TORCH_CHECK(foo(), "BAR");
|
@malfet I changed the format. Should be good now. Please check and let me know. Thanks!! |
|
@malfet Please check and merge if no further change is needed. Thanks!! |
|
@malfet can you approve and merge please |
|
@malfet please approve and merge |
|
@pytorchbot merge |
|
Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra. |
|
@pytorchbot merge |
|
Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra. |
|
@pytorchbot rebase -b viable/strict |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
…ght and kernel_width that overflows to be exactly 0
|
Successfully rebased |
pytorchmergebot
force-pushed
the
Fix_#155981
branch
from
064a94f to
b4ea89f
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorch#155989) …ght and kernel_width that overflows to be exactly 0 Fixes [pytorch#155981](pytorch#155981) Pull Request resolved: pytorch#155989 Approved by: https://github.com/malfet
pytorch#155989) …ght and kernel_width that overflows to be exactly 0 Fixes [pytorch#155981](pytorch#155981) Pull Request resolved: pytorch#155989 Approved by: https://github.com/malfet
pytorch#155989) …ght and kernel_width that overflows to be exactly 0 Fixes [pytorch#155981](pytorch#155981) Pull Request resolved: pytorch#155989 Approved by: https://github.com/malfet
5 participants
…ght and kernel_width that overflows to be exactly 0
Fixes #155981