Skip to content

[VibeCoding] build_pytorch.bat to build_pytorch.ps1 #155843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malfet wants to merge 4 commits into from
Closed

[VibeCoding] build_pytorch.bat to build_pytorch.ps1 #155843

malfet wants to merge 4 commits into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Jun 12, 2025 •
edited
Loading

@malfet
Update
2c76e65 
[ghstack-poisoned]
@malfet malfet requested a review from a team as a code owner June 12, 2025 21:21
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 12, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155843

Note: Links to docs will display an error until the docs builds have been completed.

❌ 30 New Failures, 1 Cancelled Job

As of commit a075062 with merge base 2a3b41c (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jun 12, 2025
Closed
Closed
@malfet malfet added ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Jun 12, 2025
@malfet
Update
c9ac7af 
[ghstack-poisoned]
seemethere
seemethere approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like powershell 👍🏽

malfet added 2 commits June 12, 2025 14:53
@malfet
Update
f767200 
[ghstack-poisoned]
@malfet
Update
a075062 
[ghstack-poisoned]
@atalman
Copy link
Contributor

atalman commented Jun 13, 2025

Looks good, however some syntax issue:

./windows/internal/build_wheels.ps1: line 1: syntax error near unexpected token `&'
./windows/internal/build_wheels.ps1: line 1: `& "windows/internal/vc_install_helper.bat"'

@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Aug 12, 2025
@github-actions github-actions bot closed this Sep 11, 2025
@github-actions github-actions bot deleted the gh/malfet/399/head branch October 12, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seemethere seemethere seemethere approved these changes

Assignees

No one assigned

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request Stale topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@malfet @atalman @seemethere