Skip to content

[MPS] Migrate leaky_relu (forward and backward) to Metal kernel #155571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
manuelcandales wants to merge 6 commits into from
Closed

[MPS] Migrate leaky_relu (forward and backward) to Metal kernel #155571

manuelcandales wants to merge 6 commits into from

Conversation

@manuelcandales
Copy link
Contributor

@manuelcandales manuelcandales commented Jun 10, 2025 •
edited
Loading

@manuelcandales
Update
c09c172 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155571

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 5 Pending, 2 Unrelated Failures

As of commit 235bedc with merge base d4d0ede (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Jun 10, 2025
This was referenced Jun 10, 2025
Closed
Closed
Closed
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2025

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.

Caused by:

@manuelcandales
Update
bd32a53 
[ghstack-poisoned]
@manuelcandales
Update
166ba63 
[ghstack-poisoned]
@manuelcandales manuelcandales mentioned this pull request Jun 10, 2025
Closed
@manuelcandales
Update
ce5d834 
[ghstack-poisoned]
@manuelcandales
Update
82b89cf 
[ghstack-poisoned]
@manuelcandales
Update
235bedc 
[ghstack-poisoned]
@manuelcandales manuelcandales mentioned this pull request Jun 11, 2025
Closed
@malfet malfet added the topic: not user facing topic category label Jun 11, 2025
@malfet
Copy link
Contributor

malfet commented Jun 11, 2025

@pytorchbot merge -f "Lint + MPS is green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 11, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Jun 12, 2025
@manuelcandales @pytorchmergebot
[MPS] Migrate softshrink (forward and backward) to Metal kernel (#155586
851a6fa 
)

Pull Request resolved: #155586
Approved by: https://github.com/malfet
ghstack dependencies: #155304, #155316, #155462, #155479, #155571
pytorchmergebot pushed a commit that referenced this pull request Jun 23, 2025
@manuelcandales @pytorchmergebot
[MPS] Activation kernels: do compute at float precision (#155735)
e28925a 
Pull Request resolved: #155735
Approved by: https://github.com/malfet
ghstack dependencies: #155304, #155316, #155462, #155479, #155571, #155586
@github-actions github-actions bot deleted the gh/manuelcandales/6/head branch July 14, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged release notes: mps Release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@manuelcandales @malfet @pytorchmergebot