[MPS] Migrate hardsigmoid (forward and backward) to Metal kernel #155462
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155462
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit c8c3925 with merge base d4d0ede ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/mps
Attention! native_functions.yaml was changedIf you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info. Caused by: |
| constexpr T zero(0); | ||
| constexpr T neg_three(-3); | ||
| constexpr T three(3); | ||
|
|
||
| if (self < neg_three || self > three) { | ||
| return zero; | ||
| } else { | ||
| return static_cast<T>(grad_output * (1.0f / 6.0f)); | ||
| } |
There was a problem hiding this comment.
| constexpr T zero(0); | |
| constexpr T neg_three(-3); | |
| constexpr T three(3); | |
| if (self < neg_three || self > three) { | |
| return zero; | |
| } else { | |
| return static_cast<T>(grad_output * (1.0f / 6.0f)); | |
| } | |
| constexpr auto one_over_six = 1.0f / 6.0f; | |
| return static_cast<T>(abs(float(self)) > 3.0f ? 0.0f : float(grad_output) * one_over_six) |
|
@pytorchbot merge -f "Lint + MPS is green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Pull Request resolved: #155479 Approved by: https://github.com/kulinseth, https://github.com/malfet ghstack dependencies: #155304, #155316, #155462
Stack from ghstack (oldest at bottom):