🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155460

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 6 Pending, 2 Unrelated Failures

As of commit 773e9f9 with merge base 79aef14 ():

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorchbot merge

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

• pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu)

Dig deeper by viewing the failures on hud

@pytorchbot merge -i

Merge started

Your change will be merged while ignoring the following 2 checks: pull / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, linux.2xlarge, unstable), pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchbot merge -f "This seems fine"

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

@malfet FYI I'm working on a BC-breaking note for this PR and realized that the change only affects the dimname overload of cat() / concatenate(). Was this intentional?

@jbschlosser Thank you for flagging, looks like it's not really a BC breaking, as in 2.7 the call to torch.cat with empty tensor crashed, but in 2.8 it'll return value error.

% python -c "import torch; print(torch.__version__);torch.concatenate([], dim='N')"   
2.7.1
zsh: segmentation fault  python -c 

vs

% python -c "import torch; print(torch.__version__);torch.concatenate([], dim='N')"        
2.8.0
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ValueError: expected a non-empty list of Tensors

@malfet

>>> import torch
>>> torch.cat([])
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
RuntimeError: torch.cat(): expected a non-empty list of Tensors
>>> torch.cat([], dim='N')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ValueError: expected a non-empty list of Tensors

so there's a divergence now wrt error type between dimname and non-dimname overloads

looks like it's not really a BC breaking, as in 2.7 the call to torch.cat with empty tensor crashed, but in 2.8 it'll return value error.

ah okay, sounds good! thanks for clarifying