Skip to content

Add almalinux CUDA 12.9 docker build, required for magma build #155340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tinglvv wants to merge 9 commits into from
Closed

Add almalinux CUDA 12.9 docker build, required for magma build #155340

tinglvv wants to merge 9 commits into from

Conversation

@tinglvv
Copy link
Collaborator

@tinglvv tinglvv commented Jun 6, 2025

@tinglvv tinglvv requested a review from a team as a code owner June 6, 2025 16:26
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 6, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 6, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155340

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 71 Pending

As of commit 4ac6a67 with merge base 9968c85 (image):
💚 Looks good so far! There are no failures yet. 💚

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@tinglvv tinglvv mentioned this pull request Jun 6, 2025
Open
12 tasks
@tinglvv tinglvv requested a review from jeffdaily as a code owner June 6, 2025 17:36
@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 6, 2025
@mikaylagawarecki mikaylagawarecki requested a review from malfet June 6, 2025 22:03
cyyever
cyyever reviewed Jun 7, 2025
View reviewed changes
@tinglvv tinglvv force-pushed the add-magma-cu129 branch from c18d9b8 to c741c71 Compare June 9, 2025 06:50
@tinglvv
Copy link
Collaborator Author

tinglvv commented Jun 9, 2025 •
edited
Loading

Build failure https://github.com/pytorch/pytorch/actions/runs/15528632752/job/43712799073
docker: Error response from daemon: manifest for pytorch/almalinux-builder:cuda12.9-main not found:
But the almalinux-builder:cuda12.9-main is built inside current CI. Trying add ciflow/binaries (even though no binaries rebuild needed) to reuse the docker image, per #151706.

@tinglvv
Copy link
Collaborator Author

tinglvv commented Jun 9, 2025

@clee2000 , could you also help check comment #155340 (comment)? Is there a way to reuse the almalinux docker image in the build magma workflow? Thanks!

@tinglvv tinglvv added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Jun 9, 2025
@tinglvv tinglvv removed the ciflow/binaries Trigger all binary build and upload jobs on the PR label Jun 9, 2025
@tinglvv tinglvv closed this Jun 9, 2025
@tinglvv tinglvv reopened this Jun 9, 2025
@tinglvv tinglvv changed the title Add magma build for CUDA 12.9 Add docker build for magma build for CUDA 12.9 Jun 9, 2025
@tinglvv
Copy link
Collaborator Author

tinglvv commented Jun 9, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 9, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 9, 2025

Merge failed

Reason: Approvers from one of the following sets are needed:

  • OSS CI (alband, dagitses, pytorch/pytorch-dev-infra)
  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10, ...)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet, ...)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

atalman
atalman approved these changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman atalman changed the title Add docker build for magma build for CUDA 12.9 Add almalinux CUDA 12.9 docker build, required for magma build Jun 9, 2025
@atalman
Copy link
Contributor

atalman commented Jun 9, 2025

@pytorchmergebot merge -f "lint and almalinux builds are green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 9, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@tinglvv tinglvv mentioned this pull request Jun 9, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Jun 10, 2025
@tinglvv @pytorchmergebot
Build magma-cuda 129 (#155496)
07e340e 
followup for #155340
#155196
Pull Request resolved: #155496
Approved by: https://github.com/atalman
thatgeeman pushed a commit to thatgeeman/pytorch-docathon that referenced this pull request Jun 15, 2025
@tinglvv @thatgeeman
Add almalinux CUDA 12.9 docker build, required for magma build (pytor…
6158810 
…ch#155340)

pytorch#155196
Pull Request resolved: pytorch#155340
Approved by: https://github.com/cyyever, https://github.com/atalman
thatgeeman pushed a commit to thatgeeman/pytorch-docathon that referenced this pull request Jun 15, 2025
@tinglvv @thatgeeman
Build magma-cuda 129 (pytorch#155496)
ec9aa16 
followup for pytorch#155340
pytorch#155196
Pull Request resolved: pytorch#155496
Approved by: https://github.com/atalman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cyyever cyyever cyyever approved these changes

@atalman atalman atalman approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

@malfet malfet Awaiting requested review from malfet

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tinglvv @pytorchmergebot @atalman @cyyever @pytorchbot @mikaylagawarecki