[MPS][BE] Refactor round_decimals shader code to leverage new macro #155316

manuelcandales · 2025-06-06T05:50:38Z

Stack from ghstack (oldest at bottom):

[ghstack-poisoned]

pytorch-bot · 2025-06-06T05:50:43Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155316

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 20 Pending, 3 Unrelated Failures

As of commit f8a3f92 with merge base d4d0ede ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

trunk / verify-cachebench-cpu-test / test (verify_cachebench, 1, 1, linux.2xlarge) (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu) (gh) (trunk failure)
MISSING REGRESSION TEST

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

pull / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, linux.2xlarge, unstable) (gh)
exir/backend/test/test_to_backend_multi_method.py::TestToBackendMultiMethod::test_multi_method_end_to_end

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: 9096620 Pull-Request: #155316

[ghstack-poisoned]

ghstack-source-id: 536a414 Pull-Request: #155316

[ghstack-poisoned]

ghstack-source-id: cb43865 Pull-Request: #155316

[ghstack-poisoned]

ghstack-source-id: b3252e7 Pull-Request: #155316

[ghstack-poisoned]

ghstack-source-id: dfb9c1d Pull-Request: #155316

[ghstack-poisoned]

malfet · 2025-06-10T18:19:59Z

@pytorchbot merge -f "CI is green"

pytorchmergebot · 2025-06-10T18:21:44Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-06-10T18:21:55Z

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 239370f192a6397c5ba88369a96d83e4451f6792 returned non-zero exit code 1

Auto-merging aten/src/ATen/native/mps/kernels/UnaryKernel.metal
CONFLICT (content): Merge conflict in aten/src/ATen/native/mps/kernels/UnaryKernel.metal
error: could not apply 239370f192a... [MPS][BE] Refactor round_decimals shader code to leverage new macro
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

Details for Dev Infra team

Raised by workflow job

manuelcandales · 2025-06-10T18:32:06Z

@pytorchbot merge -i

pytorchmergebot · 2025-06-10T18:34:07Z

Merge started

Your change will be merged while ignoring the following 2 checks: pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu), pull / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, linux.2xlarge, unstable)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

malfet · 2025-06-10T19:27:38Z

@pytorchbot merge -f "Merge it again"

pytorchmergebot · 2025-06-10T19:27:56Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

pytorchmergebot · 2025-06-10T19:29:43Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…5462) Pull Request resolved: #155462 Approved by: https://github.com/malfet ghstack dependencies: #155304, #155316

Pull Request resolved: #155479 Approved by: https://github.com/kulinseth, https://github.com/malfet ghstack dependencies: #155304, #155316, #155462

) Pull Request resolved: #155571 Approved by: https://github.com/malfet ghstack dependencies: #155304, #155316, #155462, #155479

) Pull Request resolved: #155586 Approved by: https://github.com/malfet ghstack dependencies: #155304, #155316, #155462, #155479, #155571

…rch#155571) Pull Request resolved: pytorch#155571 Approved by: https://github.com/malfet ghstack dependencies: pytorch#155304, pytorch#155316, pytorch#155462, pytorch#155479

Pull Request resolved: #155735 Approved by: https://github.com/malfet ghstack dependencies: #155304, #155316, #155462, #155479, #155571, #155586

Update

0e23bb4

[ghstack-poisoned]

manuelcandales requested review from kulinseth and malfet as code owners June 6, 2025 05:50

pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Jun 6, 2025

manuelcandales added a commit that referenced this pull request Jun 6, 2025

[MPS][BE] Refactor round_decimals shader code to leverage new macro

aa5b6ac

ghstack-source-id: 9096620 Pull-Request: #155316

manuelcandales mentioned this pull request Jun 6, 2025

[MPS] Implement hardshrink metal kernel #155304

Closed

Skylion007 approved these changes Jun 6, 2025

View reviewed changes

malfet approved these changes Jun 6, 2025

View reviewed changes

Update

415b4d2

[ghstack-poisoned]

manuelcandales added a commit that referenced this pull request Jun 6, 2025

[MPS][BE] Refactor round_decimals shader code to leverage new macro

8fa9d28

ghstack-source-id: 536a414 Pull-Request: #155316

Update

b4d9d47

[ghstack-poisoned]

manuelcandales added a commit that referenced this pull request Jun 6, 2025

[MPS][BE] Refactor round_decimals shader code to leverage new macro

b435695

ghstack-source-id: cb43865 Pull-Request: #155316

Update

2efcf7b

[ghstack-poisoned]

manuelcandales added a commit that referenced this pull request Jun 6, 2025

[MPS][BE] Refactor round_decimals shader code to leverage new macro

8c8b44f

ghstack-source-id: b3252e7 Pull-Request: #155316

Update

c6dbfe4

[ghstack-poisoned]

manuelcandales added a commit that referenced this pull request Jun 7, 2025

[MPS][BE] Refactor round_decimals shader code to leverage new macro

6782637

ghstack-source-id: dfb9c1d Pull-Request: #155316

manuelcandales mentioned this pull request Jun 9, 2025

[MPS] Migrate hardsigmoid (forward and backward) to Metal kernel #155462

Closed

manuelcandales added 3 commits June 9, 2025 14:19

Update

babcb1e

[ghstack-poisoned]

Update

5a45073

[ghstack-poisoned]

Update

130af9f

[ghstack-poisoned]

manuelcandales mentioned this pull request Jun 9, 2025

[MPS] Migrate hardswish (forward and backward) to Metal kernel #155479

Closed

manuelcandales added 4 commits June 9, 2025 16:00

Update

120367a

[ghstack-poisoned]

Update

b1d7907

[ghstack-poisoned]

Update

006e365

[ghstack-poisoned]

Update

f8a3f92

[ghstack-poisoned]

manuelcandales mentioned this pull request Jun 10, 2025

[MPS] Migrate leaky_relu (forward and backward) to Metal kernel #155571

Closed

malfet added the topic: not user facing topic category label Jun 10, 2025

pytorchmergebot added the merging label Jun 10, 2025

pytorchmergebot removed the merging label Jun 10, 2025

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 10, 2025

pytorchmergebot added the merging label Jun 10, 2025

manuelcandales mentioned this pull request Jun 10, 2025

[MPS] Migrate softshrink (forward and backward) to Metal kernel #155586

Closed

pytorchmergebot closed this in 91ee9ee Jun 10, 2025

pytorchmergebot added Merged and removed merging labels Jun 10, 2025

github-actions bot deleted the gh/manuelcandales/3/head branch July 13, 2025 02:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[MPS][BE] Refactor round_decimals shader code to leverage new macro #155316

[MPS][BE] Refactor round_decimals shader code to leverage new macro #155316

Uh oh!

manuelcandales commented Jun 6, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Jun 6, 2025 •

edited

Loading

Uh oh!

malfet commented Jun 10, 2025

Uh oh!

pytorchmergebot commented Jun 10, 2025

Uh oh!

pytorchmergebot commented Jun 10, 2025

Uh oh!

manuelcandales commented Jun 10, 2025

Uh oh!

pytorchmergebot commented Jun 10, 2025

Uh oh!

malfet commented Jun 10, 2025

Uh oh!

pytorchmergebot commented Jun 10, 2025

Uh oh!

pytorchmergebot commented Jun 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[MPS][BE] Refactor round_decimals shader code to leverage new macro #155316

[MPS][BE] Refactor round_decimals shader code to leverage new macro #155316

Uh oh!

Conversation

manuelcandales commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155316

⏳ 20 Pending, 3 Unrelated Failures

Uh oh!

malfet commented Jun 10, 2025

Uh oh!

pytorchmergebot commented Jun 10, 2025

Merge started

Uh oh!

pytorchmergebot commented Jun 10, 2025

Merge failed

Uh oh!

manuelcandales commented Jun 10, 2025

Uh oh!

pytorchmergebot commented Jun 10, 2025

Merge started

Uh oh!

malfet commented Jun 10, 2025

Uh oh!

pytorchmergebot commented Jun 10, 2025

Uh oh!

pytorchmergebot commented Jun 10, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

manuelcandales commented Jun 6, 2025 •

edited

Loading

pytorch-bot bot commented Jun 6, 2025 •

edited

Loading