Skip to content

[TESTING] [DO NOT MERGE] Updated triton commit pin #155117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iupaikov-amd wants to merge 5 commits into from
Closed

[TESTING] [DO NOT MERGE] Updated triton commit pin #155117

iupaikov-amd wants to merge 5 commits into from

Conversation

@iupaikov-amd
Copy link
Collaborator

@iupaikov-amd iupaikov-amd commented Jun 4, 2025 •
edited
Loading

We would like to update triton version for 2.8 release and in order to do so we will need to compile a list of possible failures that can happen with triton ToT. This PR only exists to run CI jobs and gather data for this and will remain in draft form.

Commit taken as reference: triton-lang/triton@76b6977

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155117

Note: Links to docs will display an error until the docs builds have been completed.

❌ 50 New Failures, 8 Cancelled Jobs, 2 Unrelated Failures

As of commit e0c253a with merge base d9577df (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 4, 2025
@iupaikov-amd
Copy link
Collaborator Author

iupaikov-amd commented Jun 4, 2025

@pytorchbot rebase

@iupaikov-amd iupaikov-amd mentioned this pull request Jun 4, 2025
Closed
23 tasks
@iupaikov-amd iupaikov-amd changed the title Updated triton commit pin [TESTING] [DO NOT MERGE] Updated triton commit pin Jun 4, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 4, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 4, 2025

Tried to rebase and push PR #155117, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

@jataylo jataylo added ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 keep-going Don't stop on first failure, keep running tests until the end labels Jun 4, 2025
@iupaikov-amd
Copy link
Collaborator Author

iupaikov-amd commented Jun 6, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 6, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 6, 2025

Successfully rebased iupaikov_triton_pin_update_upstream3 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout iupaikov_triton_pin_update_upstream3 && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the iupaikov_triton_pin_update_upstream3 branch from 33c1a3b to fca5226 Compare June 6, 2025 09:04
@pytorch-bot pytorch-bot bot removed ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Jun 6, 2025
@xinyazhang
Copy link
Collaborator

xinyazhang commented Jun 6, 2025

@pytorchbot label "ciflow/inductor" "ciflow/inductor-rocm" "ciflow/rocm" "ciflow/rocm-mi300" "ciflow/trunk" "keep-going"

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 6, 2025

To add these label(s) (ciflow/inductor, ciflow/inductor-rocm, ciflow/rocm, ciflow/rocm-mi300, ciflow/trunk) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@alexbaden alexbaden mentioned this pull request Jun 6, 2025
Closed
@jeffdaily jeffdaily added ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm ciflow/inductor-rocm Trigger "inductor" config CI on ROCm labels Jun 6, 2025
@pytorchmergebot pytorchmergebot force-pushed the iupaikov_triton_pin_update_upstream3 branch from 11da0d1 to 5169caf Compare June 24, 2025 16:20
@iupaikov-amd iupaikov-amd added ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Jun 24, 2025
@pytorch-bot pytorch-bot bot removed ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Jun 25, 2025
@iupaikov-amd
Copy link
Collaborator Author

iupaikov-amd commented Jun 25, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 25, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 25, 2025

Successfully rebased iupaikov_triton_pin_update_upstream3 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout iupaikov_triton_pin_update_upstream3 && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the iupaikov_triton_pin_update_upstream3 branch from 6f3c666 to e0c253a Compare June 25, 2025 13:40
@iupaikov-amd iupaikov-amd added ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Jun 25, 2025
@iupaikov-amd iupaikov-amd mentioned this pull request Jun 25, 2025
Closed
@iupaikov-amd
Copy link
Collaborator Author

iupaikov-amd commented Jul 21, 2025

Closing since triton update was complete.

@iupaikov-amd iupaikov-amd deleted the iupaikov_triton_pin_update_upstream3 branch November 3, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@desertfire desertfire Awaiting requested review from desertfire desertfire will be requested when the pull request is marked ready for review desertfire is a code owner

@Chillee Chillee Awaiting requested review from Chillee Chillee will be requested when the pull request is marked ready for review Chillee is a code owner

@eellison eellison Awaiting requested review from eellison eellison will be requested when the pull request is marked ready for review eellison is a code owner

@shunting314 shunting314 Awaiting requested review from shunting314 shunting314 will be requested when the pull request is marked ready for review shunting314 is a code owner

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily will be requested when the pull request is marked ready for review jeffdaily is a code owner

@jataylo jataylo Awaiting requested review from jataylo jataylo will be requested when the pull request is marked ready for review jataylo is a code owner

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd jithunnair-amd will be requested when the pull request is marked ready for review jithunnair-amd is a code owner

@pruthvistony pruthvistony Awaiting requested review from pruthvistony pruthvistony will be requested when the pull request is marked ready for review pruthvistony is a code owner

Assignees

No one assigned

Labels

ciflow/h100 ciflow/inductor ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 ciflow/trunk Trigger trunk jobs on your pull request keep-going Don't stop on first failure, keep running tests until the end open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@iupaikov-amd @pytorchmergebot @xinyazhang @jeffdaily @davidberard98 @pytorchbot @jataylo