[ROCm] MIOpen: Get current device from Torch rather than HIP in handle creation #154549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154549
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 8411a70 with merge base d4ab8e7 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jeffdaily
force-pushed
the
miopen_handle_creation_fix
branch
from
8b2fcae to
a0821fa
Compare
jeffdaily
added
release notes: rocm
bdhirsh
added
the
triaged
jeffdaily
approved these changes
May 28, 2025
cyyever
approved these changes
May 29, 2025
Collaborator
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 1 jobs have failed, first few of them are: linux-binary-libtorch-release / libtorch-cpu-shared-with-deps-release-build / build Details for Dev Infra teamRaised by workflow job |
Collaborator
|
Failure on this job - linux-binary-libtorch-release / libtorch-cpu-shared-with-deps-release-build / build is NOT related to this change. |
Collaborator
|
@pytorchbot merge -f "unrelated failures" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
apakbin
added a commit
to ROCm/pytorch
that referenced
this pull request
Jun 2, 2025
…e creation (pytorch#154549) Get current device from Torch rather than HIP in MIOpen handle creation. The device may have already been set from torch side, otherwise device is set to 0 for handle. Additional audits of cudnn vs miopen Handle.cpp file. Pull Request resolved: pytorch#154549 Approved by: https://github.com/jeffdaily, https://github.com/cyyever Co-authored-by: Jeff Daily <[email protected]>
apakbin
added a commit
to ROCm/pytorch
that referenced
this pull request
Jun 2, 2025
…e creation (pytorch#154549) Get current device from Torch rather than HIP in MIOpen handle creation. The device may have already been set from torch side, otherwise device is set to 0 for handle. Additional audits of cudnn vs miopen Handle.cpp file. Pull Request resolved: pytorch#154549 Approved by: https://github.com/jeffdaily, https://github.com/cyyever Co-authored-by: Jeff Daily <[email protected]>
apakbin
added a commit
to ROCm/pytorch
that referenced
this pull request
Jun 2, 2025
…e creation (pytorch#154549) Get current device from Torch rather than HIP in MIOpen handle creation. The device may have already been set from torch side, otherwise device is set to 0 for handle. Additional audits of cudnn vs miopen Handle.cpp file. Pull Request resolved: pytorch#154549 Approved by: https://github.com/jeffdaily, https://github.com/cyyever Co-authored-by: Jeff Daily <[email protected]>
apakbin
added a commit
to ROCm/pytorch
that referenced
this pull request
Jun 2, 2025
…e creation (pytorch#154549) Get current device from Torch rather than HIP in MIOpen handle creation. The device may have already been set from torch side, otherwise device is set to 0 for handle. Additional audits of cudnn vs miopen Handle.cpp file. Pull Request resolved: pytorch#154549 Approved by: https://github.com/jeffdaily, https://github.com/cyyever Co-authored-by: Jeff Daily <[email protected]>
iupaikov-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jun 4, 2025
…e creation (pytorch#154549) Get current device from Torch rather than HIP in MIOpen handle creation. The device may have already been set from torch side, otherwise device is set to 0 for handle. Additional audits of cudnn vs miopen Handle.cpp file. Pull Request resolved: pytorch#154549 Approved by: https://github.com/jeffdaily, https://github.com/cyyever Co-authored-by: Jeff Daily <[email protected]>
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jun 6, 2025
…n handle creation pytorch#154549 (#2216) (This is a cherry-pick of pytorch#154549) Get current device from Torch rather than HIP in MIOpen handle creation. The device may have already been set from torch side, otherwise device is set to 0 for handle. Additional audits of cudnn vs miopen Handle.cpp file. Pull Request resolved: pytorch#154549 Approved by: https://github.com/jeffdaily, https://github.com/cyyever Co-authored-by: Jeff Daily <[email protected]>
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jun 6, 2025
…n handle creation (pytorch#154549) (#2221) (This is a cherry-pick of pytorch#154549) Get current device from Torch rather than HIP in MIOpen handle creation. The device may have already been set from torch side, otherwise device is set to 0 for handle. Additional audits of cudnn vs miopen Handle.cpp file. Pull Request resolved: pytorch#154549 Approved by: https://github.com/jeffdaily, https://github.com/cyyever Co-authored-by: Jeff Daily <[email protected]>
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jun 6, 2025
…er than HIP in handle creation (pytorch#154549) (#2222) (This is a cherry-pick of pytorch#154549) Get current device from Torch rather than HIP in MIOpen handle creation. The device may have already been set from torch side, otherwise device is set to 0 for handle. Additional audits of cudnn vs miopen Handle.cpp file. Pull Request resolved: pytorch#154549 Approved by: https://github.com/jeffdaily, https://github.com/cyyever Co-authored-by: Jeff Daily <[email protected]>
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jun 6, 2025
…er than HIP in handle creation (pytorch#154549) (#2223) (This is a cherry-pick of pytorch#154549) Get current device from Torch rather than HIP in MIOpen handle creation. The device may have already been set from torch side, otherwise device is set to 0 for handle. Additional audits of cudnn vs miopen Handle.cpp file. Pull Request resolved: pytorch#154549 Approved by: https://github.com/jeffdaily, https://github.com/cyyever Co-authored-by: Jeff Daily <[email protected]>
okakarpa
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jun 7, 2025
…er than HIP in handle creation (pytorch#154549) (#2223) (This is a cherry-pick of pytorch#154549) Get current device from Torch rather than HIP in MIOpen handle creation. The device may have already been set from torch side, otherwise device is set to 0 for handle. Additional audits of cudnn vs miopen Handle.cpp file. Pull Request resolved: pytorch#154549 Approved by: https://github.com/jeffdaily, https://github.com/cyyever Co-authored-by: Jeff Daily <[email protected]>
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jun 7, 2025
…er than HIP in handle creation (pytorch#154549) (#2223) (This is a cherry-pick of pytorch#154549) Get current device from Torch rather than HIP in MIOpen handle creation. The device may have already been set from torch side, otherwise device is set to 0 for handle. Additional audits of cudnn vs miopen Handle.cpp file. Pull Request resolved: pytorch#154549 Approved by: https://github.com/jeffdaily, https://github.com/cyyever Co-authored-by: Jeff Daily <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get current device from Torch rather than HIP in MIOpen handle creation. The device may have already been set from torch side, otherwise device is set to 0 for handle. Additional audits of cudnn vs miopen Handle.cpp file.
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd