[MPS] index copy impl #154326
[MPS] index copy impl #154326
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154326
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c06e421 with merge base 53ecb81 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Attention! native_functions.yaml was changedIf you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info. Caused by: |
Isalia20
added
module: mps
| mtl_setArgs<8>(computeEncoder, input_strides_buffer, output_strides_buffer, source_strides_buffer); | ||
| } | ||
| MTLSize gridSize = MTLSizeMake(numThreads, 1, 1); | ||
| MTLSize threadgroupSize = MTLSizeMake(std::min(numThreads, 256), 1, 1); |
There was a problem hiding this comment.
ah probably a leftover, changed it to maxtotal thread groups
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
malfet
added
ciflow/mps
malfet
left a comment
malfet
left a comment
There was a problem hiding this comment.
LGTM, though I think it'll have problem with typecasts, but I'll submit followups
| test_cases = [ | ||
| ((2, 8, 4, 5), 0, [1]), | ||
| ((8, 8, 4, 5), 0, [0, 3, 2, 7, 6]), | ||
| ((2, 8, 4, 5), 1, [0, 3, 2, 7, 6]), | ||
| ((2, 8, 4, 5), 2, [3, 0, 1]), | ||
| ((2, 8, 4, 5), 3, [2, 3, 0]), | ||
| ((2, 3, 3), -1, [1, 2]) | ||
| ] | ||
|
|
||
| for args in test_cases: | ||
| helper(*args) |
There was a problem hiding this comment.
Please stop using this anti-pattern and start using templatized arguments instead.
Also, does it really cover something that OpInfo is not atm?
There was a problem hiding this comment.
This test is for strided tensors only since I noticed they weren't being covered with OpInfo ones
|
@pytorchbot merge -f "Lint + MPS is green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Second most requested op according to pytorch#154052 Pull Request resolved: pytorch#154326 Approved by: https://github.com/malfet
4 participants
Second most requested op according to #154052
cc @kulinseth @albanD @malfet @DenisVieriu97 @jhavukainen