Fix profiler on cpython-3.13 #154037
Merged
Fix profiler on cpython-3.13 #154037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per [PEP 667](https://peps.python.org/pep-0667/) `PyFrame_GetLocals` no longer returns dict, but rather instance of `PyFrameLocalsProxy_Type`, so calling `PyDict_GetItemString` is no longer valid(it will always return None) and must be replaced with `PyMapping_GetItemString` Tested by partially reverting #141674 full revert will be done in the followup PR Fixes #148273 Pull Request resolved: #153848 Approved by: https://github.com/Skylion007 (cherry picked from commit c0343b1)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154037
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 19b80ad with merge base 924a247 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Per PEP 667
PyFrame_GetLocalsno longer returns dict, but rather instance ofPyFrameLocalsProxy_Type, so callingPyDict_GetItemStringis no longer valid(it will always return None) and must be replaced withPyMapping_GetItemStringTested by partially reverting #141674 full revert will be done in the followup PR
Fixes #148273