[ROCm] update state check for test_trace_while_active* #153545
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153545
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ab98a99 with merge base 0c6c778 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
module: rocm
jeffdaily
added
ciflow/periodic
pytorch-bot
bot
removed
ciflow/periodic
jeffdaily
added
ciflow/periodic
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
May 16, 2025
…2110) When timing in enabled, ROCR runtime used to sleep for a small amount which ensured that the application saw the correct state. However, for perf reasons this sleep was removed and now the state is not guaranteed to be "started". That's why, I updated the test state check to be either "started" or "scheduled" Fixes https://ontrack-internal.amd.com/browse/SWDEV-525883 Upstream PR: pytorch#153545
pragupta
added a commit
to pragupta/pytorch
that referenced
this pull request
May 28, 2025
…OCm#2110) When timing in enabled, ROCR runtime used to sleep for a small amount which ensured that the application saw the correct state. However, for perf reasons this sleep was removed and now the state is not guaranteed to be "started". That's why, I updated the test state check to be either "started" or "scheduled" Fixes https://ontrack-internal.amd.com/browse/SWDEV-525883 Upstream PR: pytorch#153545 (cherry picked from commit 8a1ad2c)
pragupta
added a commit
to pragupta/pytorch
that referenced
this pull request
May 28, 2025
…OCm#2110) When timing in enabled, ROCR runtime used to sleep for a small amount which ensured that the application saw the correct state. However, for perf reasons this sleep was removed and now the state is not guaranteed to be "started". That's why, I updated the test state check to be either "started" or "scheduled" Fixes https://ontrack-internal.amd.com/browse/SWDEV-525883 Upstream PR: pytorch#153545 (cherry picked from commit 8a1ad2c)
This was referenced May 28, 2025
jeffdaily
approved these changes
May 28, 2025
Collaborator
jeffdaily
left a comment
jeffdaily
left a comment
There was a problem hiding this comment.
Approved with one nit to change.
pytorch-bot
bot
removed
ciflow/periodic
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
jeffdaily
added
ciflow/rocm
pruthvistony
approved these changes
May 28, 2025
pruthvistony
added
ciflow/inductor-rocm
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
May 28, 2025
#2201) …#2110) When timing in enabled, ROCR runtime used to sleep for a small amount which ensured that the application saw the correct state. However, for perf reasons this sleep was removed and now the state is not guaranteed to be "started". That's why, I updated the test state check to be either "started" or "scheduled" Fixes https://ontrack-internal.amd.com/browse/SWDEV-525883 Upstream PR: pytorch#153545 (cherry picked from commit 8a1ad2c) Fixes #ISSUE_NUMBER
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
May 28, 2025
#2202) …#2110) When timing in enabled, ROCR runtime used to sleep for a small amount which ensured that the application saw the correct state. However, for perf reasons this sleep was removed and now the state is not guaranteed to be "started". That's why, I updated the test state check to be either "started" or "scheduled" Fixes https://ontrack-internal.amd.com/browse/SWDEV-525883 Upstream PR: pytorch#153545 (cherry picked from commit 8a1ad2c) Fixes #ISSUE_NUMBER
Collaborator
|
@pytorchbot rebase |
Collaborator
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
When timing in enabled, ROCR runtime used to sleep for a small amount which ensured that the application saw the correct state. However, for perf reasons this sleep was removed and now the state is not guaranteed to be "started". That's why, I updated the test state check to be either "started" or "scheduled"
Co-authored-by: Jeff Daily <[email protected]>
Collaborator
|
Successfully rebased |
pytorchmergebot
force-pushed
the
pg-navi31-jira-upstream
branch
from
1b33d3f to
ab98a99
Compare
pytorch-bot
bot
removed
ciflow/rocm
jeffdaily
added
ciflow/rocm
Collaborator
|
@pytorchbot merge -f "unrelated rocm failures, rocm-only change to test logic" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When timing is enabled, ROCR runtime used to sleep for a small amount which ensured that the application saw the correct state. However, for perf reasons this sleep was removed and now the state is not guaranteed to be "started". That's why I updated the test state check to be either "started" or "scheduled"
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd