add from_pretrained method to EmbeddingBag #15273
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I think this failure ci failure is not related to my change but just a failure on the build machine itself. |
Contributor
Contributor
Author
|
I can make those changes as well |
Collaborator
|
LGTM too, but please also add the other options @weiyangfb mentioned. |
Contributor
|
Sorry, one more nit: can we just add some smoketests for the new options? They're not smoketested at all in the test suite at the moment. |
Contributor
Author
|
@ezyang let me know if that is what you are looking for. |
soumith
approved these changes
Dec 26, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EmbeddingBagmodule does not include afrom_pretrainedmethod like theEmbeddingmodule. I added it for consistency between the two modules.