Remove spurious memo argument in Module.parameters() #1527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaszke
reviewed
May 10, 2017
torch/nn/modules/module.py
Outdated
| <class 'torch.FloatTensor'> (20L, 1L, 5L, 5L) | ||
| """ | ||
| for name, param in self.named_parameters(): | ||
| for name, param in self.named_parameters(memo): |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
wjaskowski
changed the title
Contributor
Author
|
I see. Fixed. |
Contributor
|
Thanks! |
caogang
added a commit
to caogang/pytorch
that referenced
this pull request
May 11, 2017
* master: (26 commits) Fix Linear function Fix comparison functions Expose variable attribute of AccumulateGrad Don't modify non-volatile grads in zero_grad Minor fix in Prod backward Add new flags to Variable.backward Replace retain_variables with retain_graph Improve output wrapping logic in autograd Remove spurious memo argument in Module.parameters() (pytorch#1527) Make torch.cat not synchronize the host and device Reference counting documentation. (pytorch#1520) Restore examples with keepdim=True default. Explicitly pass keepdim=False for tests that require it. Change keepdim default to False. Fix test_normalize NN test. Add a keepdim test to torch_test. Make (non-legacy) nn backwards compatible. Add autograd tests for keepdim Add documentation for keepdim. Change all legacy/nn modules to use keepdim=True (even if tests don't fail). ... # Conflicts: # torch/autograd/_functions/reduce.py # torch/autograd/variable.py
Jiaming-Liu
pushed a commit
to Jiaming-Liu/pytorch
that referenced
this pull request
May 18, 2017
zasdfgbnm
pushed a commit
to zasdfgbnm/pytorch
that referenced
this pull request
Mar 31, 2022
pytorch-bot bot
pushed a commit
that referenced
this pull request
Aug 16, 2024
skip unit test on !rocm
pytorch-bot bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
skip unit test on !rocm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.