[pytree][dynamo] make `tree_*` functions accept both Python and C++ `PyTreeSpec` #152624

XuehaiPan · 2025-05-01T18:25:04Z

Stack from ghstack (oldest at bottom):

-> [pytree][dynamo] make tree_* functions accept both Python and C++ PyTreeSpec #152624

cc @zou3519 @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo @chenyang78

[ghstack-poisoned]

pytorch-bot · 2025-05-01T18:25:08Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152624

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

ghstack-source-id: 9e7ffa4 Pull-Request-resolved: pytorch#152624

torch/utils/_pytree.py

[ghstack-poisoned]

ghstack-source-id: 48f548b Pull-Request-resolved: pytorch#152624

[ghstack-poisoned]

ghstack-source-id: 8864039 Pull-Request-resolved: pytorch#152624

[ghstack-poisoned]

Lucaskabela

Some suggestions on simiplifying the comparisson

torch/utils/_cxx_pytree.py

torch/utils/_pytree.py

[ghstack-poisoned]

ghstack-source-id: 71cb3a2 Pull-Request-resolved: #152624

Lucaskabela

Thanks for the changes! LGTM

[ghstack-poisoned]

ghstack-source-id: a66b8e0 Pull-Request-resolved: #152624

XuehaiPan · 2025-11-28T12:15:41Z

@pytorchbot merge

pytorchmergebot · 2025-11-28T12:18:37Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

ghstack-source-id: a66b8e0 Pull-Request-resolved: #152624

[ghstack-poisoned]

ghstack-source-id: 12b06c4 Pull-Request-resolved: #152624

pytorchmergebot · 2025-11-28T12:28:44Z

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team

Raised by workflow job

XuehaiPan · 2025-11-28T12:29:00Z

@pytorchbot merge

pytorchmergebot · 2025-11-28T12:30:49Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

XuehaiPan · 2025-11-28T12:46:47Z

@pytorchbot merge

pytorchmergebot · 2025-11-28T12:47:05Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

XuehaiPan · 2025-11-28T12:47:17Z

@pytorchbot merge

pytorchmergebot · 2025-11-28T12:50:24Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-11-28T18:48:00Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

XuehaiPan · 2025-11-29T02:46:42Z

@pytorchbot merge -f "ROCm CI is not available now, other CI tests are passed"

pytorchmergebot · 2025-11-29T02:48:18Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…PyTreeSpec` (#152624) Pull Request resolved: #152624 Approved by: https://github.com/Lucaskabela

Update

864d750

[ghstack-poisoned]

pytorch-bot bot added ciflow/inductor module: dynamo labels May 1, 2025

XuehaiPan changed the title ~~[pytree] make tree_* functions to accept both Python and C++ PyTreeSpec~~ [pytree] make tree_* functions accept both Python and C++ PyTreeSpec May 1, 2025

XuehaiPan added module: pytree ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels May 1, 2025

XuehaiPan requested review from angelayi and zou3519 May 1, 2025 18:27

Update

e830571

[ghstack-poisoned]

pytorchbot added the open source label May 1, 2025

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 1, 2025

[pytree] make tree_* functions accept both Python and C++ PyTreeSpec

2b64f20

ghstack-source-id: 9e7ffa4 Pull-Request-resolved: pytorch#152624

Skylion007 reviewed May 2, 2025

View reviewed changes

torch/utils/_pytree.py Show resolved Hide resolved

torch/utils/_pytree.py Outdated Show resolved Hide resolved

XuehaiPan added 2 commits May 3, 2025 00:40

Update

2fac214

[ghstack-poisoned]

Update

7976822

[ghstack-poisoned]

Update

7e9405d

[ghstack-poisoned]

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 2, 2025

[pytree] make tree_* functions accept both Python and C++ PyTreeSpec

ecb87a9

ghstack-source-id: 48f548b Pull-Request-resolved: pytorch#152624

Update

c202d5b

[ghstack-poisoned]

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 2, 2025

[pytree] make tree_* functions accept both Python and C++ PyTreeSpec

4ea491e

ghstack-source-id: 8864039 Pull-Request-resolved: pytorch#152624

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 3, 2025

[pytree] make tree_* functions accept both Python and C++ PyTreeSpec

10f8106

ghstack-source-id: 8864039 Pull-Request-resolved: pytorch#152624

Update

e3e16ad

[ghstack-poisoned]

Lucaskabela requested changes Nov 24, 2025

View reviewed changes

torch/utils/_cxx_pytree.py Outdated Show resolved Hide resolved

torch/utils/_pytree.py Show resolved Hide resolved

Update

b63b095

[ghstack-poisoned]

XuehaiPan added a commit that referenced this pull request Nov 25, 2025

[pytree] make tree_* functions accept both Python and C++ PyTreeSpec

df7d4ec

ghstack-source-id: 71cb3a2 Pull-Request-resolved: #152624

XuehaiPan requested a review from Lucaskabela November 25, 2025 04:21

Lucaskabela approved these changes Nov 25, 2025

View reviewed changes

Update

10b4ab1

[ghstack-poisoned]

XuehaiPan added a commit that referenced this pull request Nov 27, 2025

[pytree] make tree_* functions accept both Python and C++ PyTreeSpec

6025fec

ghstack-source-id: a66b8e0 Pull-Request-resolved: #152624

pytorchmergebot added the merging label Nov 28, 2025

XuehaiPan added a commit that referenced this pull request Nov 28, 2025

[pytree] make tree_* functions accept both Python and C++ PyTreeSpec

3afb746

ghstack-source-id: a66b8e0 Pull-Request-resolved: #152624

Update

20bb78b

[ghstack-poisoned]

XuehaiPan added a commit that referenced this pull request Nov 28, 2025

[pytree] make tree_* functions accept both Python and C++ PyTreeSpec

3ceff94

ghstack-source-id: 12b06c4 Pull-Request-resolved: #152624

pytorchmergebot removed the merging label Nov 28, 2025

pytorchmergebot added the merging label Nov 28, 2025

pytorchmergebot closed this in 409a5fe Nov 29, 2025

pytorchmergebot added Merged and removed merging labels Nov 29, 2025

[pytree][dynamo] make tree_* functions accept both Python and C++ PyTreeSpec #152624

[pytree][dynamo] make tree_* functions accept both Python and C++ PyTreeSpec #152624

Uh oh!

Conversation

XuehaiPan commented May 1, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152624

❗ 2 Active SEVs

Uh oh!

Uh oh!

Uh oh!

Lucaskabela left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Lucaskabela left a comment

Choose a reason for hiding this comment

Uh oh!

XuehaiPan commented Nov 28, 2025

Uh oh!

pytorchmergebot commented Nov 28, 2025

Merge started

Uh oh!

pytorchmergebot commented Nov 28, 2025

Merge failed

Uh oh!

XuehaiPan commented Nov 28, 2025

Uh oh!

pytorchmergebot commented Nov 28, 2025

Merge started

Uh oh!

XuehaiPan commented Nov 28, 2025

Uh oh!

pytorchmergebot commented Nov 28, 2025

Uh oh!

XuehaiPan commented Nov 28, 2025

Uh oh!

pytorchmergebot commented Nov 28, 2025

Merge started

Uh oh!

pytorchmergebot commented Nov 28, 2025

Uh oh!

XuehaiPan commented Nov 29, 2025

Uh oh!

pytorchmergebot commented Nov 29, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[pytree][dynamo] make `tree_*` functions accept both Python and C++ `PyTreeSpec` #152624

[pytree][dynamo] make `tree_*` functions accept both Python and C++ `PyTreeSpec` #152624

XuehaiPan commented May 1, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented May 1, 2025 •

edited

Loading