Skip to content

[BE] Migrate all add/sub ops to Metal kernels #152510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malfet wants to merge 9 commits into from
Closed

[BE] Migrate all add/sub ops to Metal kernels #152510

malfet wants to merge 9 commits into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Apr 30, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

As typecasting harness shoudl take care of all permutations
Fix bug in exec_binary_kernel where it was not properly downcasting CPU double/complexDouble scalars to floats

Fixes #152582

@malfet
Update
c127301 
[ghstack-poisoned]
@malfet malfet requested a review from kulinseth as a code owner April 30, 2025 03:47
This was referenced Apr 30, 2025
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 30, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152510

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 60 Pending

As of commit 99cd53a with merge base d35e900 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the ciflow/mps Run MPS tests (subset of trunk) label Apr 30, 2025
@malfet malfet mentioned this pull request Apr 30, 2025
Closed
@pytorch-bot pytorch-bot bot added the release notes: mps Release notes category label Apr 30, 2025
@malfet malfet mentioned this pull request Apr 30, 2025
Closed
@malfet malfet added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Apr 30, 2025
@malfet malfet requested review from Skylion007 and dcci April 30, 2025 04:43
@malfet
Update
9035d9c 
[ghstack-poisoned]
@malfet
Update
e8a9ea3 
[ghstack-poisoned]
@malfet malfet mentioned this pull request Apr 30, 2025
Closed
@malfet
Update
b039441 
[ghstack-poisoned]
@malfet malfet mentioned this pull request Apr 30, 2025
Closed
malfet added 2 commits April 30, 2025 19:37
@malfet
Update
0dbb79f 
[ghstack-poisoned]
@malfet
Update
249b08a 
[ghstack-poisoned]
malfet and others added 2 commits May 1, 2025 05:52
@malfet
Update
c50030b 
[ghstack-poisoned]
@malfet
Update
a8f22ef 
[ghstack-poisoned]
@malfet malfet mentioned this pull request May 1, 2025
Closed
@malfet
Update
99cd53a 
[ghstack-poisoned]
malfet added a commit that referenced this pull request May 1, 2025
@malfet
[BE] Migrate all add/sub ops to Metal kernels
4f10dc8 
As typecasting harness shoudl take care of all permutations

ghstack-source-id: fa8e544
Pull Request resolved: #152510
@malfet
Copy link
Contributor Author

malfet commented May 1, 2025

@pytorchbot merge -f "Lint + MPS are green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented May 1, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@skotapati skotapati mentioned this pull request May 1, 2025
Closed
@atalman
Copy link
Contributor

atalman commented May 7, 2025

@pytorchbot cherry-pick --onto release/2.7 -c critical

@pytorchbot
Copy link
Collaborator

pytorchbot commented May 7, 2025

Cherry picking #152510

Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 52cbcac640dc1d8c12a6f8308799c75d45c6fc4a returned non-zero exit code 1

Auto-merging aten/src/ATen/native/mps/OperationUtils.mm
CONFLICT (content): Merge conflict in aten/src/ATen/native/mps/OperationUtils.mm
Auto-merging aten/src/ATen/native/mps/operations/BinaryKernel.mm
CONFLICT (content): Merge conflict in aten/src/ATen/native/mps/operations/BinaryKernel.mm
Auto-merging aten/src/ATen/native/mps/operations/BinaryOps.mm
CONFLICT (content): Merge conflict in aten/src/ATen/native/mps/operations/BinaryOps.mm
error: could not apply 52cbcac640d... [BE] Migrate all add/sub ops to Metal kernels (#152510)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Details for Dev Infra team Raised by workflow job

This was referenced May 7, 2025
Merged
Closed
Closed
@github-actions github-actions bot deleted the gh/malfet/314/head branch June 15, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@dcci dcci dcci approved these changes

@cyyever cyyever cyyever approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: mps Release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@malfet @pytorchmergebot @atalman @pytorchbot @Skylion007 @dcci @cyyever