Skip to content

[ROCm] Use almalinux docker files for building Magma #152488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeffdaily wants to merge 2 commits into from
Closed

[ROCm] Use almalinux docker files for building Magma #152488

jeffdaily wants to merge 2 commits into from

Conversation

@jeffdaily
Copy link
Collaborator

@jeffdaily jeffdaily commented Apr 29, 2025 •
edited by atalman
Loading

@jeffdaily jeffdaily requested a review from atalman April 29, 2025 23:07
@jeffdaily jeffdaily requested a review from a team as a code owner April 29, 2025 23:07
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 29, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152488

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 41a012f with merge base a4a7716 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/rocm Trigger "default" config CI on ROCm module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels Apr 29, 2025
@jeffdaily jeffdaily marked this pull request as draft April 29, 2025 23:10
@jeffdaily jeffdaily marked this pull request as ready for review April 30, 2025 16:15
atalman
atalman approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman
Copy link
Contributor

atalman commented Apr 30, 2025

@pytorchbot merge -f "magma and lint workflows are green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 30, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

Assignees

No one assigned

Labels

ciflow/rocm Trigger "default" config CI on ROCm Merged module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

difficulty creating magma tarball when new rocm or cuda versions are deployed

4 participants

@jeffdaily @atalman @pytorchmergebot @pytorchbot