Use almalinux docker files for building Magma #152358
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152358
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit d8087d6 with merge base 5f4c8e4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Discussed this approach with @jeffdaily for magma-rocm builds |
atalman
added
module: cuda
ZainRizvi
left a comment
ZainRizvi
left a comment
There was a problem hiding this comment.
Why is removing Cuda 12.4 relevant to using almalinux?
|
CUDA 12.4 was deprecated: #145544 - No reason keeping old build that we don't use |
|
@pytorchmergebot merge -f "lint and magma builds are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: Approvers from one of the following sets are needed:
|
|
@pytorchmergebot merge -f "lint and magma builds are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes #151707 for ROCm Magma builds. See also #152358. Depends on #152492. Pull Request resolved: #152488 Approved by: https://github.com/atalman
6 participants
Resolves #151707 for CUDA Nvidia Magma builds.
Removes deprecated cuda 12.4 build.
Using
pytorch/manylinux2_28-builderimage for magma build creates circular dependency.For a while for magma builds we used
conda-builderimage since it does not have circular dependency:https://github.com/pytorch/builder/blob/release/2.4/magma/Makefile#L13
However during migration to pytorch/pytorch: #139888 we introduced circular dependency using Manylinux 2.28 docker image.
Hence using almalinux image which suppose to be general usage image
Please note: Magma builds using Docker build : https://github.com/pytorch/pytorch/blob/main/.ci/magma/README.md we can look into migrating them to Docker images if required as a followup BE change if needed
TODO: Make same change for rocm builds. I believe some more work for rocm is required, since maga-rocm is requires rocm dev, utils and lib to be installed : https://github.com/pytorch/pytorch/blob/main/.ci/docker/common/install_rocm.sh
cc @ptrblck @msaroufim @eqy @jerryzh168 @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd