Return ConstantVariable(None) from WithExitFunctionVariable.exit to prevent NoneType crash inside autocast exception path #152013

wdziurdz · 2025-04-23T12:59:35Z

Fixes #152012

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames

pytorch-bot · 2025-04-23T12:59:38Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152013

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 42 Pending

As of commit 0a4b8a0 with merge base 797768c ():

NEW FAILURE - The following job has failed:

pull / cuda12.4-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu) (gh)
REGRESSION: benchmark ('aotdispatcher_inference_nosubclass_cpu', 'compile_time_instruction_count') failed, actual result 2074106382 is 1.57% higher than expected 2042000000 ±+1.50% if this is an expected regression, please update the expected results.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

wdziurdz · 2025-04-23T13:01:18Z

@pytorchbot label "topic: not user facing"

jansel · 2025-04-24T20:54:23Z

Add a test?

wdziurdz · 2025-04-28T12:23:26Z

Add a test?

done

jansel · 2025-04-28T18:17:16Z

@pytorchbot merge

pytorchmergebot · 2025-04-28T18:19:50Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-04-28T18:25:13Z

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

jansel · 2025-04-28T20:17:25Z

@wdziurdz can you fix this lints?

wdziurdz · 2025-04-29T06:55:45Z

@wdziurdz can you fix this lints?

done

jansel · 2025-04-29T18:22:52Z

@pytorchbot merge

pytorchmergebot · 2025-04-29T18:25:14Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-04-29T18:30:44Z

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

jansel · 2025-04-29T21:41:45Z

@pytorchbot rebase

to see if that if that fixes docker issue in CI

pytorchmergebot · 2025-04-29T21:43:26Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2025-04-29T21:43:29Z

Successfully rebased main onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout main && git pull --rebase)

jansel · 2025-04-29T23:52:31Z

@pytorchbot merge

pytorchmergebot · 2025-04-29T23:56:00Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-04-30T00:54:15Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

pull / cuda12.4-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu)

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

jansel · 2025-04-30T01:36:13Z

Whoops sorry @wdziurdz I tried to update the expected results for you to fixed the unrelated CI issue, but I pushed the wrong ref and it closed the PR. Now it won't let me update your branch that the PR is closed.

I put up a copy with the fix here in #152503

…revent NoneType crash inside autocast exception path (#152503) Copy of #152013 with PR time benchmarks updated (regressions seem unrelated) Pull Request resolved: #152503 Approved by: https://github.com/anijain2305, https://github.com/Skylion007 Co-authored-by: Witold Dziurdz <[email protected]>

…revent NoneType crash inside autocast exception path (pytorch#152503) Copy of pytorch#152013 with PR time benchmarks updated (regressions seem unrelated) Pull Request resolved: pytorch#152503 Approved by: https://github.com/anijain2305, https://github.com/Skylion007 Co-authored-by: Witold Dziurdz <[email protected]>

…revent NoneType crash inside autocast exception path (#153612) Return ConstantVariable(None) from WithExitFunctionVariable.exit to prevent NoneType crash inside autocast exception path (#152503) Copy of #152013 with PR time benchmarks updated (regressions seem unrelated) Pull Request resolved: #152503 Approved by: https://github.com/anijain2305, https://github.com/Skylion007 Co-authored-by: Jason Ansel <[email protected]>

pytorch-bot bot added the module: dynamo label Apr 23, 2025

pytorch-bot bot added the topic: not user facing topic category label Apr 23, 2025

pytorchbot added the open source label Apr 23, 2025

colesbury requested a review from jansel April 23, 2025 18:29

colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 23, 2025

jansel approved these changes Apr 24, 2025

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 28, 2025

pytorchmergebot added the merging label Apr 28, 2025

pytorchmergebot removed the merging label Apr 28, 2025

pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Apr 29, 2025

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 29, 2025

pytorchmergebot added the merging label Apr 29, 2025

pytorchmergebot removed the merging label Apr 29, 2025

pytorchmergebot force-pushed the main branch from 2df0204 to 0a4b8a0 Compare April 29, 2025 21:43

pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Apr 29, 2025

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 29, 2025

pytorchmergebot added the merging label Apr 29, 2025

pytorchmergebot removed the merging label Apr 30, 2025

jansel closed this Apr 30, 2025

jansel force-pushed the main branch from 0a4b8a0 to 75f38df Compare April 30, 2025 01:27

pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Apr 30, 2025

jansel mentioned this pull request Apr 30, 2025

Return ConstantVariable(None) from WithExitFunctionVariable.exit to prevent NoneType crash inside autocast exception path #152503

Closed

wdziurdz mentioned this pull request May 6, 2025

[dynamo] Use getattr when accessing self.value.__module__ in SkipFunctionVariable #152320

Closed

Return ConstantVariable(None) from WithExitFunctionVariable.exit to prevent NoneType crash inside autocast exception path #152013

Return ConstantVariable(None) from WithExitFunctionVariable.exit to prevent NoneType crash inside autocast exception path #152013

Uh oh!

Conversation

wdziurdz commented Apr 23, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152013

❌ 1 New Failure, 42 Pending

Uh oh!

wdziurdz commented Apr 23, 2025

Uh oh!

jansel commented Apr 24, 2025

Uh oh!

wdziurdz commented Apr 28, 2025

Uh oh!

jansel commented Apr 28, 2025

Uh oh!

pytorchmergebot commented Apr 28, 2025

Merge started

Uh oh!

pytorchmergebot commented Apr 28, 2025

Merge failed

Uh oh!

jansel commented Apr 28, 2025

Uh oh!

wdziurdz commented Apr 29, 2025

Uh oh!

jansel commented Apr 29, 2025

Uh oh!

pytorchmergebot commented Apr 29, 2025

Merge started

Uh oh!

pytorchmergebot commented Apr 29, 2025

Merge failed

Uh oh!

jansel commented Apr 29, 2025

Uh oh!

pytorchmergebot commented Apr 29, 2025

Uh oh!

pytorchmergebot commented Apr 29, 2025

Uh oh!

jansel commented Apr 29, 2025

Uh oh!

pytorchmergebot commented Apr 29, 2025

Merge started

Uh oh!

pytorchmergebot commented Apr 30, 2025

Merge failed

Uh oh!

jansel commented Apr 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

wdziurdz commented Apr 23, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Apr 23, 2025 •

edited

Loading