Skip to content

[ROCm][CI/CD] create ROCm 6.4 images, part 1, skip magma tarball #151236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jithunnair-amd wants to merge 5 commits into from
Closed

[ROCm][CI/CD] create ROCm 6.4 images, part 1, skip magma tarball #151236

jithunnair-amd wants to merge 5 commits into from

Conversation

@jithunnair-amd
Copy link
Collaborator

@jithunnair-amd jithunnair-amd commented Apr 14, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 14, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151236

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 7 Pending

As of commit ebc68ff with merge base 24b3ab9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/rocm Trigger "default" config CI on ROCm module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels Apr 14, 2025
@jeffdaily
Copy link
Collaborator

jeffdaily commented Apr 14, 2025

@huydhn can we get a rocm 6.4 docker repo registry set up?

name unknown: The repository with name 'pytorch/manylinux2_28-builder-rocm6.4' does not exist in the registry with id '308535385114'

@jeffdaily
Copy link
Collaborator

jeffdaily commented Apr 14, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 14, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 14, 2025

Tried to rebase and push PR #151236, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

@jeffdaily jeffdaily marked this pull request as ready for review April 15, 2025 19:36
@jeffdaily jeffdaily requested review from a team and jeffdaily as code owners April 15, 2025 19:36
@jeffdaily
Copy link
Collaborator

jeffdaily commented Apr 15, 2025

@pytorchbot merge -f "all image build jobs successful, do not need default rocm CI to run so skipping it"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 15, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 15, 2025

Merge failed

Reason: PR #151236 has not been reviewed yet

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@jeffdaily
Copy link
Collaborator

jeffdaily commented Apr 15, 2025

@pytorchbot merge -f "all image build jobs successful, do not need default rocm CI to run so skipping it"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 15, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

timocafe pushed a commit to timocafe/pytorch that referenced this pull request Apr 16, 2025
@jeffdaily @timocafe
[ROCm][CI/CD] create ROCm 6.4 images, part 1, skip magma tarball (pyt…
a46fea6 
…orch#151236)

Pull Request resolved: pytorch#151236
Approved by: https://github.com/jeffdaily

Co-authored-by: Jeff Daily <[email protected]>
amathewc pushed a commit to amathewc/pytorch that referenced this pull request Apr 17, 2025
@jeffdaily @amathewc
[ROCm][CI/CD] create ROCm 6.4 images, part 1, skip magma tarball (pyt…
5378a35 
…orch#151236)

Pull Request resolved: pytorch#151236
Approved by: https://github.com/jeffdaily

Co-authored-by: Jeff Daily <[email protected]>
@jeffdaily jeffdaily mentioned this pull request Apr 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffdaily jeffdaily jeffdaily approved these changes

Assignees

No one assigned

Labels

ciflow/rocm Trigger "default" config CI on ROCm Merged module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jithunnair-amd @jeffdaily @pytorchmergebot @pytorchbot