[ROCm][TunableOp] Support submatrices in offline tuning #151138
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naromero77amd
requested review from
IvanYashchuk,
eqy,
lezcano,
nikitaved and
syed-ahmed
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151138
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (3 Unrelated Failures)As of commit fa0e6a9 with merge base 0ad2c5d ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
module: rocm
Collaborator
Author
|
Confirming that new UTs ran in shard2 and |
mikaylagawarecki
added
the
triaged
naromero77amd
added
ciflow/rocm
pytorch-bot
bot
added
ciflow/rocm
jeffdaily
approved these changes
Apr 18, 2025
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
naromero77amd
added a commit
to ROCm/pytorch
that referenced
this pull request
May 8, 2025
This PR adds support for submatrices in offline tuning for: - GEMM - GEMM and bias - ScaledGEMM - Batch Strided GEMM New UTs to cover submatrices. Submatrices for strided batch API is not part of this PR and will be done seperately. There is also a bug fix for offline tuning for full matrix for GEMM and bias in the `NT` case. Offline and online UTs were updated to cover this corner case. To improve code readability, swapped definition of transA and transB. Pull Request resolved: pytorch#151138 Approved by: https://github.com/jeffdaily (cherry picked from commit f6c1cf0)
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
May 8, 2025
…ledGEMM rowwise fix (#2106) Align TunableOp UTs, features, and bug fixes with upstream PyTorch main UTs: pytorch#148982 pytorch#149930 pytorch#150142 pytorch#150463 Feature: offline tuning for submatrices: pytorch#151138 Bug Fix: ScaledGEMM rowwise pytorch#152403 --------- Co-authored-by: Jeff Daily <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for submatrices in offline tuning for:
New UTs to cover submatrices. Submatrices for strided batch API is not part of this PR and will be done seperately.
There is also a bug fix for offline tuning for full matrix for GEMM and bias in the
NTcase. Offline and online UTs were updated to cover this corner case.To improve code readability, swapped definition of transA and transB.
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang