[jit] improve deep equality check in alias annotation test #15031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
eellison
approved these changes
Dec 11, 2018
|
|
||
| #undef TORCH_FORALL_TAGS | ||
|
|
||
| void IValue::dump() const { |
Contributor
There was a problem hiding this comment.
We should standardize dump as an api for printing out objects... Sometimes it's toStr() etc
Member
Author
There was a problem hiding this comment.
I am for dump(), since that's what nodes and graphs use already.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@suo is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
apaszke
approved these changes
Dec 11, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@suo is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Dec 11, 2018
Summary: Previously we were returning true if either IValue wasn't a tensor, which…is bad Pull Request resolved: pytorch/pytorch#15031 Differential Revision: D13409759 Pulled By: suo fbshipit-source-id: f8bdcd05d334c1276ce46f55812065d358c1ff5d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were returning true if either IValue wasn't a tensor, which…is bad