[easy] Use config patch to toggle capture_scalar_output #150036
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150036
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 552d7be with merge base ce54c43 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
[ghstack-poisoned]
angelayi
approved these changes
Mar 26, 2025
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This was referenced Mar 27, 2025
Contributor
|
FYI this stack causes a slight regression in the perf 1-3% not that bad |
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 28, 2025
Pull Request resolved: #150090 Approved by: https://github.com/eellison, https://github.com/zou3519 ghstack dependencies: #149087, #149667, #150036, #148953
laithsakka
added a commit
that referenced
this pull request
Mar 28, 2025
…ges landing while test is unstable " The test went unstable and now I am playing a race to make it back stable ! diffs that are published while the test was unstable are landing, with out changing expected results. <img width="512" alt="Screenshot 2025-03-27 at 10 48 21 PM" src="https://github.com/user-attachments/assets/225bcad9-6e06-4a66-8438-8b70ff9dbeff" /> Two more PRs causing slight regressions: 1) the stack on #150036 2) #150137 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames anijain2305 eellison huydhn when do you think we will have the APIs to access results on oss storage available so we do not have to worry about this racing again? Also is there a way to accelerate unstability in this after we land it? cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
laithsakka
added a commit
that referenced
this pull request
Mar 28, 2025
…e test is unstable " The test went unstable and now I am playing a race to make it back stable ! diffs that are published while the test was unstable are landing, with out changing expected results. <img width="512" alt="Screenshot 2025-03-27 at 10 48 21 PM" src="https://github.com/user-attachments/assets/225bcad9-6e06-4a66-8438-8b70ff9dbeff" /> Two more PRs causing slight regressions: 1) the stack on #150036 2) #150137 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames anijain2305 eellison huydhn when do you think we will have the APIs to access results on oss storage available so we do not have to worry about this racing again? Also is there a way to accelerate unstability in this after we land it? cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
Pull Request resolved: pytorch#150036 Approved by: https://github.com/angelayi ghstack dependencies: pytorch#149087, pytorch#149667
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
…pytorch#148953) Pull Request resolved: pytorch#148953 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#149087, pytorch#149667, pytorch#150036
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
Pull Request resolved: pytorch#150090 Approved by: https://github.com/eellison, https://github.com/zou3519 ghstack dependencies: pytorch#149087, pytorch#149667, pytorch#150036, pytorch#148953
laithsakka
added a commit
that referenced
this pull request
May 10, 2025
…ges landing while test is unstable " The test went unstable and now I am playing a race to make it back stable ! diffs that are published while the test was unstable are landing, with out changing expected results. <img width="512" alt="Screenshot 2025-03-27 at 10 48 21 PM" src="https://github.com/user-attachments/assets/225bcad9-6e06-4a66-8438-8b70ff9dbeff" /> Two more PRs causing slight regressions: 1) the stack on #150036 2) #150137 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames anijain2305 eellison huydhn when do you think we will have the APIs to access results on oss storage available so we do not have to worry about this racing again? Also is there a way to accelerate unstability in this after we land it? cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
laithsakka
added a commit
that referenced
this pull request
May 10, 2025
…e test is unstable " The test went unstable and now I am playing a race to make it back stable ! diffs that are published while the test was unstable are landing, with out changing expected results. <img width="512" alt="Screenshot 2025-03-27 at 10 48 21 PM" src="https://github.com/user-attachments/assets/225bcad9-6e06-4a66-8438-8b70ff9dbeff" /> Two more PRs causing slight regressions: 1) the stack on #150036 2) #150137 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames anijain2305 eellison huydhn when do you think we will have the APIs to access results on oss storage available so we do not have to worry about this racing again? Also is there a way to accelerate unstability in this after we land it? cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):