[ROCm][TunableOp] TunableOp Context Manager for unit tests #149930
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naromero77amd
requested review from
IvanYashchuk,
lezcano and
nikitaved
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149930
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 94b6284 with merge base db92d0f ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
module: rocm
jeffdaily
requested changes
Mar 25, 2025
test/test_linalg.py
Outdated
Comment on lines
4681
to
4683
| tunableop_ctx = self._tunableop_ctx | ||
|
|
||
| with tunableop_ctx(): |
Collaborator
There was a problem hiding this comment.
Is there a reason this isn't a one-liner? Would need to fix here and elsewhere.
Suggested change
| tunableop_ctx = self._tunableop_ctx | |
| with tunableop_ctx(): | |
| with self._tunableop_ctx(): |
naromero77amd
added
the
ciflow/rocm-mi300
jeffdaily
approved these changes
Mar 25, 2025
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
…49930) This PR is cleanup only. There are no feature changes or bug fixes. We create a TunableOp context manager for setting up and cleanup. We re-write TunableOp unit tests in terms of this context manager. Ultimately reduces the amount of copy-paste code. Pull Request resolved: pytorch#149930 Approved by: https://github.com/jeffdaily
naromero77amd
added a commit
to ROCm/pytorch
that referenced
this pull request
May 8, 2025
…49930) This PR is cleanup only. There are no feature changes or bug fixes. We create a TunableOp context manager for setting up and cleanup. We re-write TunableOp unit tests in terms of this context manager. Ultimately reduces the amount of copy-paste code. Pull Request resolved: pytorch#149930 Approved by: https://github.com/jeffdaily (cherry picked from commit 45b1173)
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
May 8, 2025
…ledGEMM rowwise fix (#2106) Align TunableOp UTs, features, and bug fixes with upstream PyTorch main UTs: pytorch#148982 pytorch#149930 pytorch#150142 pytorch#150463 Feature: offline tuning for submatrices: pytorch#151138 Bug Fix: ScaledGEMM rowwise pytorch#152403 --------- Co-authored-by: Jeff Daily <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is cleanup only. There are no feature changes or bug fixes.
We create a TunableOp context manager for setting up and cleanup. We re-write TunableOp unit tests in terms of this context manager. Ultimately reduces the amount of copy-paste code.
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang