-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[invoke_subgraph][fake tensor cache] Add a finalizer for id hashed objects #149667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jects [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149667
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit 33f79b0 with merge base ce54c43 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…d hashed objects" [ghstack-poisoned]
zou3519
reviewed
Mar 24, 2025
test/test_fake_tensor.py
Outdated
| extract_tensor_metadata(a), | ||
| extract_tensor_metadata(b), | ||
| ) | ||
| # self.assertTrue(count_invoke_subgraph_keys() > 0) |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's up here?
zou3519
approved these changes
Mar 24, 2025
…d hashed objects" [ghstack-poisoned]
…d hashed objects" [ghstack-poisoned]
…d hashed objects" [ghstack-poisoned]
…d hashed objects" [ghstack-poisoned]
Collaborator
|
Starting merge as part of PR stack under #150036 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 27, 2025
Pull Request resolved: #150036 Approved by: https://github.com/angelayi ghstack dependencies: #149087, #149667
This was referenced Mar 27, 2025
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 28, 2025
Pull Request resolved: #150090 Approved by: https://github.com/eellison, https://github.com/zou3519 ghstack dependencies: #149087, #149667, #150036, #148953
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
…jects (pytorch#149667) Pull Request resolved: pytorch#149667 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#149087
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
Pull Request resolved: pytorch#150036 Approved by: https://github.com/angelayi ghstack dependencies: pytorch#149087, pytorch#149667
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
…pytorch#148953) Pull Request resolved: pytorch#148953 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#149087, pytorch#149667, pytorch#150036
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
Pull Request resolved: pytorch#150090 Approved by: https://github.com/eellison, https://github.com/zou3519 ghstack dependencies: pytorch#149087, pytorch#149667, pytorch#150036, pytorch#148953
Divigroup-RAP
pushed a commit
to Divigroup-RAP/PYTORCH
that referenced
this pull request
Apr 22, 2025
…jects ghstack-source-id: 9f51c17 Pull Request resolved: pytorch/pytorch#149667
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/inductor
ciflow/trunk
Trigger trunk jobs on your pull request
Merged
topic: not user facing
topic category
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):