-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Fix is_nonzero for more than one elem tensors #149637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix is_nonzero for more than one elem tensors #149637
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149637
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 297884d with merge base 2c4bc65 ( NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv Differential Revision: [D71560442](https://our.internmc.facebook.com/intern/diff/D71560442) [ghstack-poisoned]
|
@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv Differential Revision: [D71560442](https://our.internmc.facebook.com/intern/diff/D71560442) [ghstack-poisoned]
Pull Request resolved: #149637 cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @imported-using-ghimport Differential Revision: [D71560442](https://our.internmc.facebook.com/intern/diff/D71560442/) ghstack-source-id: 273256663
|
This pull request was exported from Phabricator. Differential Revision: D71560442 |
|
@pytorchbot merge -i (Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally) |
Merge startedYour change will be merged while ignoring the following 3 checks: pull / linux-docs / build-docs-python-false, trunk / linux-focal-rocm6.3-py3.10 / test (default, 1, 2, linux.rocm.gpu.2), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (dynamic_cpu_inductor_huggingface, 1, 1, linux.8xlarge.amx) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Differential Revision: [D71560442](https://our.internmc.facebook.com/intern/diff/D71560442) Pull Request resolved: pytorch#149637 Approved by: https://github.com/pianpwk
…154164) This was added in #149637, torch._check can handle unbacked there is no need for size oblivious reasoning here. Note this does not make is_nonzero unbacked friendly. but that is a different story. I ran the test added in #149637 for veirfication. Pull Request resolved: #154164 Approved by: https://github.com/aorenste, https://github.com/bobrenjc93 ghstack dependencies: #154154
Stack from ghstack (oldest at bottom):
cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv
Differential Revision: D71560442