Remove custom kwargs before calling BuildExtension.init(...) #149636

janeyx99 · 2025-03-20T17:11:54Z

Remove custom kwargs before calling BuildExtension.__init__(...)

This should fix what is going on in https://fb.workplace.com/chat/t/100068823519463#:~:text=https%3A//github.com/pytorch/rl/actions/runs/13974012630/job/39123001095

cc @vmoens

Remove custom kwargs before calling BuildExtension.__init__(...)

pytorch-bot · 2025-03-20T17:11:57Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149636

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 6e4a5cb with merge base 1d9401b ():

NEW FAILURE - The following job has failed:

Check Labels / Check labels (gh)
RuntimeError: Error checking labels: PR does not have required labels

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions · 2025-03-20T17:12:21Z

This PR needs a `release notes:` label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

torch/utils/cpp_extension.py

Co-authored-by: Vincent Moens <[email protected]>

malfet · 2025-03-21T02:04:24Z

torch/utils/cpp_extension.py

-
        self.use_ninja = kwargs.get('use_ninja', True)
+
+        filtered_kwargs = {kw: val for kw, val in kwargs.items() if kw not in ["no_python_abi_suffix", "use_ninja"]}


I wonder if better way to address that is to define user_options (or boolean_options)
Not sure how long something like that were supported though, see https://github.com/pypa/setuptools/blob/7c859e017368360ba66c8cc591279d8964c031bc/setuptools/_distutils/command/build_ext.py#L100

Skylion007 · 2025-03-21T18:50:22Z

torch/utils/cpp_extension.py

-
        self.use_ninja = kwargs.get('use_ninja', True)
+
+        filtered_kwargs = {kw: val for kw, val in kwargs.items() if kw not in ["no_python_abi_suffix", "use_ninja"]}


Nit should use tuple or set for contains check. Set should be optimized since it's a check against literal strings.

…it__(...) (#2002) Port fix from pytorch#149636 Update to torchvision branch https://github.com/ROCm/vision/tree/release/0.15 Validation:http://rocm-ci.amd.com/view/Release-6.4/job/pytorch2.0-manylinux-wheels_rel-6.4/32/ --------- Co-authored-by: Jithun Nair <[email protected]>

…t__(...) (#2003) Port fix from pytorch#149636 Update to torchvision branch https://github.com/ROCm/vision/tree/release/0.18 Validation:http://rocm-ci.amd.com/view/Release-6.4/job/pytorch2.3-manylinux-wheels_rel-6.4/29/ --------- Co-authored-by: Jithun Nair <[email protected]>

…it__(...) (#2006) Port fix from pytorch#149636 Update to torchvision branch https://github.com/ROCm/vision/tree/release/0.19 Validation:http://rocm-ci.amd.com/view/Release-6.4/job/pytorch2.4-manylinux-wheels_rel-6.4/33/ --------- Co-authored-by: Jithun Nair <[email protected]>

…it__(...) (#2004) Port fix from pytorch#149636 Validation:http://rocm-ci.amd.com/view/Release-6.4/job/pytorch2.5-manylinux-wheels_rel-6.4/45/ Co-authored-by: Jithun Nair <[email protected]>

…it__(...) (#2005) Port fix from pytorch#149636 Validation:http://rocm-ci.amd.com/view/Release-6.4/job/pytorch2.6-manylinux-wheels_rel-6.4-preview/22/ Co-authored-by: Jithun Nair <[email protected]>

jithunnair-amd · 2025-04-23T14:37:30Z

@janeyx99 This PR is still open, but the fix in this PR was helpful for us to workaround some build issues on our end. Is there a plan to merge this PR, or has an alternative fix been put in place?

janeyx99 · 2025-04-23T15:27:09Z

@jithunnair-amd Ah I had put this on the backburner given that setuptools was updated and the workaround was working. I can prioritize landing a more sustainable long term solution if there are people waiting on this PR

…it__(...) (#2005) Port fix from pytorch#149636 Validation:http://rocm-ci.amd.com/view/Release-6.4/job/pytorch2.6-manylinux-wheels_rel-6.4-preview/22/ Co-authored-by: Jithun Nair <[email protected]> (cherry picked from commit 7ad5a0a)

jithunnair-amd · 2025-04-24T03:51:29Z

given that setuptools was updated and the workaround was working

@janeyx99 Could you please provide some links for the fix you refer to: "given that setuptools was updated and the workaround was working"?

janeyx99 · 2025-04-24T16:38:40Z

Ah I just mean the newer setuptools don't have the issue: https://pypi.org/project/setuptools/

…it__(...) (#2005) Port fix from pytorch#149636 Validation:http://rocm-ci.amd.com/view/Release-6.4/job/pytorch2.6-manylinux-wheels_rel-6.4-preview/22/ Co-authored-by: Jithun Nair <[email protected]> (cherry picked from commit 7ad5a0a)

github-actions · 2025-06-23T16:41:13Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Conform to new setuptools update 77.0.3

5ab974b

Remove custom kwargs before calling BuildExtension.__init__(...)

janeyx99 requested review from ezyang, fmassa and soumith as code owners March 20, 2025 17:11

vmoens reviewed Mar 20, 2025

View reviewed changes

torch/utils/cpp_extension.py Outdated Show resolved Hide resolved

rbavery mentioned this pull request Mar 20, 2025

unexpected kwarg 'no_python_abi_suffix' when installing stable version of pytorch with sam2 #149658

Open

Update torch/utils/cpp_extension.py

6e4a5cb

Co-authored-by: Vincent Moens <[email protected]>

malfet reviewed Mar 21, 2025

View reviewed changes

Skylion007 reviewed Mar 21, 2025

View reviewed changes

jithunnair-amd added a commit to ROCm/pytorch that referenced this pull request Mar 26, 2025

Port fix from pytorch#149636

53d4bf4

ethanwee1 pushed a commit to ROCm/pytorch that referenced this pull request Mar 26, 2025

Port fix from pytorch#149636

1e0f92c

ethanwee1 pushed a commit to ROCm/pytorch that referenced this pull request Mar 26, 2025

Port fix from pytorch#149636

8c5528d

ethanwee1 pushed a commit to ROCm/pytorch that referenced this pull request Mar 26, 2025

Port fix from pytorch#149636

e15cf86

ethanwee1 pushed a commit to ROCm/pytorch that referenced this pull request Mar 26, 2025

Port fix from pytorch#149636

c41376d

github-actions bot added the Stale label Jun 23, 2025

github-actions bot closed this Jul 23, 2025

github-actions bot deleted the comply-with-setuptools branch August 23, 2025 02:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove custom kwargs before calling BuildExtension.init(...) #149636

Remove custom kwargs before calling BuildExtension.init(...) #149636

Uh oh!

janeyx99 commented Mar 20, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Mar 20, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 20, 2025

Uh oh!

Uh oh!

malfet Mar 21, 2025

Uh oh!

Skylion007 Mar 21, 2025

Uh oh!

jithunnair-amd commented Apr 23, 2025

Uh oh!

janeyx99 commented Apr 23, 2025

Uh oh!

jithunnair-amd commented Apr 24, 2025 •

edited

Loading

Uh oh!

janeyx99 commented Apr 24, 2025

Uh oh!

github-actions bot commented Jun 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants


		self.use_ninja = kwargs.get('use_ninja', True)

		filtered_kwargs = {kw: val for kw, val in kwargs.items() if kw not in ["no_python_abi_suffix", "use_ninja"]}

Remove custom kwargs before calling BuildExtension.__init__(...) #149636

Remove custom kwargs before calling BuildExtension.__init__(...) #149636

Uh oh!

Conversation

janeyx99 commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149636

❌ 1 New Failure

Uh oh!

github-actions bot commented Mar 20, 2025

This PR needs a release notes: label

Uh oh!

Uh oh!

malfet Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

Skylion007 Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

jithunnair-amd commented Apr 23, 2025

Uh oh!

janeyx99 commented Apr 23, 2025

Uh oh!

jithunnair-amd commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

janeyx99 commented Apr 24, 2025

Uh oh!

github-actions bot commented Jun 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Remove custom kwargs before calling BuildExtension.init(...) #149636

Remove custom kwargs before calling BuildExtension.init(...) #149636

janeyx99 commented Mar 20, 2025 •

edited

Loading

pytorch-bot bot commented Mar 20, 2025 •

edited

Loading

This PR needs a `release notes:` label

jithunnair-amd commented Apr 24, 2025 •

edited

Loading