cd: Add no-cache for test binaries #149218
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to make it so that we don't experience issues like https://github.com/pytorch/vision/actions/runs/13861462856/job/38795684317#step:13:212 ``` ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them. unknown package: Expected sha256 8e34a6f02ac5a63763251953063a19ba9df855ac2c8a13ef409dfef708e2ba26 Got 341156cc5067488565c1e103be6e95105b0fc0d87d8ac24ff8891f63fd33216f ```
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149218
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cf70253 with merge base 1bdbf12 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ZainRizvi
approved these changes
Mar 14, 2025
atalman
approved these changes
Mar 14, 2025
Contributor
atalman
left a comment
atalman
left a comment
There was a problem hiding this comment.
lgtm @ZainRizvi please include small log for validation of this change
malfet
approved these changes
Mar 14, 2025
Contributor
malfet
left a comment
malfet
left a comment
There was a problem hiding this comment.
I'm not sure if those flags would be respected by CloudFront....
Member
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Contributor
|
@pytorchmergebot revert -c nosignal -m "Lets not use no-cache flags on test binaries" |
Collaborator
|
@pytorchbot successfully started a revert job. Check the current status here. |
Collaborator
|
@seemethere your PR has been successfully reverted. |
pytorchmergebot
added a commit
that referenced
this pull request
Aug 22, 2025
This reverts commit 523bffd. Reverted #149218 on behalf of https://github.com/atalman due to Lets not use no-cache flags on test binaries ([comment](#149218 (comment)))
charliermarsh
added a commit
to astral-sh/uv
that referenced
this pull request
Aug 24, 2025
## Summary After chatting with the PyTorch team, it looks like some number of wheels were accidentally uploaded with `no-cache,no-store,must-revalidate` due to pytorch/pytorch#149218. They're going to correct this for the respective wheels. I've encouraged them to set an immutable caching header for these files, and it might happen. But even if this isn't set, by default we only allow these wheels to be cached for 600s, since the other wheels don't include a `Cache-Control` header at all (but do include a `Last-Modified`, so we cache based on our heuristic: `Freshness lifetime heuristically assumed because of presence of last-modified header: 600s`). This probably leads to tons of unnecessary downloads for users over time. Andrey from the PyTorch team agreed that we should do this. Closes #15480.
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
This reverts commit 523bffd. Reverted pytorch#149218 on behalf of https://github.com/atalman due to Lets not use no-cache flags on test binaries ([comment](pytorch#149218 (comment)))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make it so that we don't experience issues like https://github.com/pytorch/vision/actions/runs/13861462856/job/38795684317#step:13:212