[Profiler][HPU] Fix incorrect availabilities for HPU #148663
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148663
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Pending, 1 Unrelated FailureAs of commit 9653c4b with merge base 79aa174 ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "topic: not user facing" |
|
@sraikund16 Please review the current changes. This commit fixes the issue that was introduced by the incorrect availabilities for HPU devices in this PR: #148182 |
colesbury
added
the
triaged
|
@albanD can you review and merge? It's a small bug fix for HPU only that would be great if it went in still in PT2.7. |
|
@Skylion007 Could you please review these changes? It's a small bug fix for HPU only. |
|
@pytorchbot merge |
|
Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra. |
EikanWang
added
ciflow/trunk
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
refactoring the code to be device agrostic would be best. But sure.
|
@pytorchbot revert -c ghfirst -m "Sorry but this is breaking internally. @albanD, could you please help get this relanded? See D71052806 for more details. To validate the fixes internally, you can follow the instructions here: https://fburl.com/fixing-ghfirst-reverts" Errors look like: |
|
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit 28b7880. Reverted #148663 on behalf of https://github.com/ZainRizvi due to Sorry but this is breaking internally. @albanD, could you please help get this relanded? See D71052806 for more details. To validate the fixes internally, you can follow the instructions here: https://fburl.com/fixing-ghfirst-reverts ([comment](#148663 (comment)))
|
@wdziurdz your PR has been successfully reverted. |
pytorch-bot
bot
dismissed stale reviews from jeromean, Skylion007, EikanWang, and albanD
This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
I'm pretty sure intenrnal failure is unrelated
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 3 mandatory check(s) failed. The first few are:
Dig deeper by viewing the failures on hud |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 5 checks: pull / linux-focal-cuda12.6-py3.10-gcc11-sm89 / build, pull / linux-focal-cuda12.6-py3.10-gcc11 / build, pull / unstable-linux-focal-cuda12.6-py3.10-gcc11-sm89-xfail / build, pull / linux-focal-cpu-py3.10-gcc11-bazel-test / build-and-test (default, 1, 1, linux.4xlarge), trunk / libtorch-linux-focal-cuda12.4-py3.10-gcc9-debug / build Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot cherry-pick --onto release/2.7 --fixes "Fix incorrect availability for HPU-only devices in the profiler" -c regression |
Fixes #148661 Pull Request resolved: #148663 Approved by: https://github.com/jeromean, https://github.com/albanD (cherry picked from commit 75c8b7d)
Cherry picking #148663The cherry pick PR is at #149115 and it is linked with issue Fix incorrect availability for HPU-only devices in the profiler. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
[Profiler][HPU] Fix incorrect availabilities for HPU (#148663) Fixes #148661 Pull Request resolved: #148663 Approved by: https://github.com/jeromean, https://github.com/albanD (cherry picked from commit 75c8b7d) Co-authored-by: wdziurdz <[email protected]>
10 participants
Fixes #148661