Skip to content

[CI] [inductor] Add cu126 inductor jobs and move away cu124 #148612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tinglvv wants to merge 5 commits into from
Closed

[CI] [inductor] Add cu126 inductor jobs and move away cu124 #148612

tinglvv wants to merge 5 commits into from

Conversation

@tinglvv
Copy link
Collaborator

@tinglvv tinglvv commented Mar 5, 2025 •
edited by pytorch-bot bot
Loading

#145570

breaking #140793 into eager and inductor benchmarks to unblock

Seems many inductor yml are added after initial change was prepared.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @atalman @malfet @nWEIdia @ptrblck

@tinglvv tinglvv requested review from a team and jeffdaily as code owners March 5, 2025 22:10
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 5, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148612

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 5 Pending, 6 Unrelated Failures

As of commit e9dee42 with merge base 98458e5 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

nWEIdia
nWEIdia reviewed Mar 5, 2025
View reviewed changes
nWEIdia
nWEIdia requested changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@nWEIdia nWEIdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, please just take care of the base docker image in docker-builds.yml.

@tinglvv tinglvv added the keep-going Don't stop on first failure, keep running tests until the end label Mar 6, 2025
@tinglvv tinglvv mentioned this pull request Mar 6, 2025
Closed
26 tasks
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 6, 2025

Warning: Unknown label ciflow/inductor-perf-test-nightly.
Currently recognized labels are

  • ciflow/binaries
  • ciflow/binaries_libtorch
  • ciflow/binaries_wheel
  • ciflow/inductor
  • ciflow/inductor-periodic
  • ciflow/inductor-rocm
  • ciflow/inductor-perf-test-nightly-rocm
  • ciflow/inductor-perf-compare
  • ciflow/inductor-micro-benchmark
  • ciflow/inductor-micro-benchmark-cpu-x86
  • ciflow/inductor-cu126
  • ciflow/linux-aarch64
  • ciflow/mps
  • ciflow/nightly
  • ciflow/periodic
  • ciflow/rocm
  • ciflow/rocm-mi300
  • ciflow/s390
  • ciflow/slow
  • ciflow/trunk
  • ciflow/unstable
  • ciflow/xpu
  • ciflow/torchbench
  • ciflow/autoformat

Please add the new label to .github/pytorch-probot.yml

atalman
atalman reviewed Mar 6, 2025
View reviewed changes
@atalman atalman mentioned this pull request Mar 6, 2025
Open
@atalman
Copy link
Contributor

atalman commented Mar 7, 2025

@pytorchmergebot merge -f "This has been 3 iteration of these tests. Merging. lint is green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Mar 7, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

malfet added a commit that referenced this pull request Mar 7, 2025
@malfet
Fix lint
1e8b101 
Regression introduced by merge conflict of #148612
@malfet malfet mentioned this pull request Mar 7, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Mar 7, 2025
@malfet @pytorchmergebot
Delete duplicate entry from docker-builds.yml (#148782)
d8dc700 
Regression introduced by merge conflict of #148612

Pull Request resolved: #148782
Approved by: https://github.com/atalman
@albanD
Copy link
Collaborator

albanD commented Mar 7, 2025

@atalman lint was NOT green

@malfet
Copy link
Contributor

malfet commented Mar 7, 2025 •
edited
Loading

@atalman lint was NOT green

But it was, see https://github.com/pytorch/pytorch/actions/runs/13722848195 (Also I've already submitted a forward fix...)

@atalman atalman mentioned this pull request Mar 7, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Mar 10, 2025
@atalman @pytorchmergebot
Add timm_efficientnet to flaky models after cuda 12.6 update in CI/CD (…
2068235 
…#148788)

After #148612
This model have become flaky

Tracking this regression in an issue : #148699

Pull Request resolved: #148788
Approved by: https://github.com/izaitsevfb, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

@nWEIdia nWEIdia nWEIdia approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

Assignees

No one assigned

Labels

ciflow/inductor ciflow/inductor-micro-benchmark ciflow/inductor-perf-compare ciflow/inductor-perf-test-nightly Trigger nightly inductor perf tests ciflow/inductor-periodic keep-going Don't stop on first failure, keep running tests until the end Merged module: dynamo open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tinglvv @atalman @pytorchmergebot @albanD @malfet @nWEIdia @pytorchbot