Skip to content

Enable Direct Use of Arm Compute Library (ACL) in ATen #148581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fadara01 wants to merge 1 commit into from
Closed

Enable Direct Use of Arm Compute Library (ACL) in ATen #148581

fadara01 wants to merge 1 commit into from

Conversation

@fadara01
Copy link
Collaborator

@fadara01 fadara01 commented Mar 5, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

ACL is already built with PyTorch as a shared library when USE_MKLDNN_ACL is set.
Currently, it is only used indirectly in ATen via oneDNN for AArch64 targets. However there are cases where it makes sense to utilize ACL directly without oneDNN as an intermediary - e.g. quantization. See #145942, #147337, #146620.
This patch enables such use cases by exposing ACL to ATen

@fadara01
Update
8dac614 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148581

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 8dac614 with merge base 6c3492b (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

fadara01 added a commit that referenced this pull request Mar 5, 2025
@fadara01
Enable Direct Use of Arm Compute Library (ACL) in ATen
d7108f2 
ACL is already built with PyTorch as a shared library when USE_MKLDNN_ACL is set.
Currently, it is only used indirectly in ATen via oneDNN for AArch64 targets. However there are cases where it makes sense to utilize ACL directly without  oneDNN as an intermediary - e.g. quantization. See #145942, #147337, #146620.
This patch enables such use cases by exposing ACL to ATen

ghstack-source-id: 266c621
Pull Request resolved: #148581
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@fadara01
Copy link
Collaborator Author

fadara01 commented Mar 18, 2025

Closing this as it is a duplicate of #148584 which has been merged.

@fadara01 fadara01 closed this Mar 18, 2025
@github-actions github-actions bot deleted the gh/fadara01/1/head branch April 20, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fadara01 @pytorchbot