Skip to content

[BE][pytree] cleanup parameterized pytree tests #148569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
XuehaiPan wants to merge 49 commits into from
Closed

[BE][pytree] cleanup parameterized pytree tests #148569

XuehaiPan wants to merge 49 commits into from

Conversation

@XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Mar 5, 2025 •
edited by pytorch-bot bot
Loading

Stack from ghstack (oldest at bottom):

Changes:

  1. Rename import py_pytree -> python_pytree. We will add a new test for generic_pytree in a follow-up PR after [pytree] Add public pytree module torch.utils.pytree #137400
  2. Reuse the parametrize test marker:
parametrize_pytree_module = parametrize(
    "pytree",
    [
        subtest(python_pytree, name="python"),
        *([subtest(cxx_pytree, name="cxx")] if not IS_FBCODE else []),
        subtest(pytree, name="generic"),
    ],
)

cc @zou3519 @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela

@XuehaiPan
Update
d796d11 
[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 5, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148569

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 436d2ac with merge base 8f43454 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@XuehaiPan
Update
e07b3eb 
[ghstack-poisoned]
@XuehaiPan
Update
8df3189 
[ghstack-poisoned]
@XuehaiPan XuehaiPan marked this pull request as ready for review March 5, 2025 17:07
@XuehaiPan XuehaiPan requested a review from zou3519 March 5, 2025 17:08
@XuehaiPan
Update
488dc1a 
[ghstack-poisoned]
@XuehaiPan
Update
4a909bd 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Mar 5, 2025
@XuehaiPan
[BE][pytree] cleanup parameterized pytree tests
23ffcf4 
ghstack-source-id: 6edf88d
Pull Request resolved: #148569
@XuehaiPan
Update
ad11cb5 
[ghstack-poisoned]
@XuehaiPan
Update
db28242 
[ghstack-poisoned]
@XuehaiPan
Update
c229de2 
[ghstack-poisoned]
@XuehaiPan XuehaiPan mentioned this pull request Mar 6, 2025
Closed
@XuehaiPan XuehaiPan mentioned this pull request Mar 6, 2025
Closed
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Mar 6, 2025
@XuehaiPan
[BE][pytree] cleanup parameterized pytree tests
1dbed75 
ghstack-source-id: cf23022
Pull Request resolved: pytorch#148569
@XuehaiPan
Update
18baabc 
[ghstack-poisoned]
@XuehaiPan
Update
1752ca5 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 18, 2025
@XuehaiPan
[BE][pytree] cleanup parameterized pytree tests
3409314 
ghstack-source-id: 623dcfe
Pull Request resolved: pytorch#148569
@XuehaiPan
Update
42e4033 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 27, 2025
@XuehaiPan
[BE][pytree] cleanup parameterized pytree tests
5dfcabf 
ghstack-source-id: 8f55ae4
Pull Request resolved: pytorch#148569
@XuehaiPan
Update
67bab07 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 28, 2025
@XuehaiPan
[BE][pytree] cleanup parameterized pytree tests
a309ae4 
ghstack-source-id: 0f01c70
Pull Request resolved: pytorch#148569
@XuehaiPan
Update
42afa1f 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 3, 2025
@XuehaiPan
[BE][pytree] cleanup parameterized pytree tests
3774424 
ghstack-source-id: c4972e1
Pull Request resolved: pytorch#148569
@XuehaiPan
Update
dca7326 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 9, 2025
@XuehaiPan
[BE][pytree] cleanup parameterized pytree tests
f6278ca 
ghstack-source-id: 485472b
Pull Request resolved: pytorch#148569
@XuehaiPan
Update
1695ac0 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 25, 2025
@XuehaiPan
[BE][pytree] cleanup parameterized pytree tests
d99fe1e 
ghstack-source-id: 49a5aef
Pull Request resolved: pytorch#148569
@XuehaiPan
Update
9b0ae05 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 31, 2025
@XuehaiPan
[BE][pytree] cleanup parameterized pytree tests
106b042 
ghstack-source-id: c02291a
Pull Request resolved: pytorch#148569
@XuehaiPan
Update
436d2ac 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Aug 17, 2025
@XuehaiPan
[BE][pytree] cleanup parameterized pytree tests
de1366d 
ghstack-source-id: 646e1c1
Pull Request resolved: pytorch#148569
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Aug 17, 2025
@XuehaiPan
[BE][pytree] cleanup parameterized pytree tests
b9ac8e8 
ghstack-source-id: 646e1c1
Pull Request resolved: pytorch#148569
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Oct 16, 2025
@XuehaiPan XuehaiPan closed this Oct 16, 2025
@github-actions github-actions bot deleted the gh/XuehaiPan/257/head branch November 16, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@zou3519 zou3519 Awaiting requested review from zou3519

Assignees

No one assigned

Labels

ciflow/inductor module: dynamo module: pytree open source Stale topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@XuehaiPan @zou3519 @pytorchbot