Skip to content

Disable some SVE autovec #148489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Nicoshev wants to merge 1 commit into from
Closed

Disable some SVE autovec #148489

Nicoshev wants to merge 1 commit into from

Conversation

@Nicoshev
Copy link
Contributor

@Nicoshev Nicoshev commented Mar 4, 2025 •
edited by pytorch-bot bot
Loading

Summary: autovec miscompiles on patterns of the type:

for (const auto i : c10::irange())

Same issue as described in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117001 and addressed by #137795 for gcc, but not clang

Test Plan:
buck2 build //caffe2/caffe2/fb/transforms:sigrid_interface

Differential Revision: D70422723

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @malfet @snadampal @milpuz01

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148489

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 0c6710b with merge base 9db9593 (image):

NEW FAILURE - The following job has failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Mar 4, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 4, 2025

This pull request was exported from Phabricator. Differential Revision: D70422723

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 4, 2025

This pull request was exported from Phabricator. Differential Revision: D70422723

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 4, 2025

This pull request was exported from Phabricator. Differential Revision: D70422723

@Nicoshev @facebook-github-bot
[caffe2] Disable autovec (pytorch#148489)
0c6710b 
Summary:
Pull Request resolved: pytorch#148489

autovec miscompiles on patterns of the type: for (const auto i : c10::irange()

Test Plan:
buck2 build //caffe2/caffe2/fb/transforms:sigrid_interface

We are going to deploy it on ads workloads

Differential Revision: D70422723
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 5, 2025

This pull request was exported from Phabricator. Differential Revision: D70422723

@Nicoshev Nicoshev changed the title [Ads] Slice convertIdScoreListFeaturesToIValue in half Disable some SVE autovec Mar 7, 2025
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 7, 2025
malfet
malfet approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will follow up on the ways to combine with decorator added in #137795

@malfet malfet added module: third_party module: arm Related to ARM architectures builds of PyTorch. Includes Apple M1 topic: bug fixes topic category labels Mar 7, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 7, 2025

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Mar 7, 2025

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@ZainRizvi
Copy link
Contributor

ZainRizvi commented Mar 10, 2025 •
edited
Loading

@Nicoshev can you please add a release label and retry the merge here? Or rather, fix the release note I added in case it's not the best one?

@ZainRizvi ZainRizvi added the release notes: cpp release notes category label Mar 10, 2025
@ZainRizvi
Copy link
Contributor

ZainRizvi commented Mar 10, 2025

@pytorchmergebot merge -f "merged internally"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Mar 10, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: arm Related to ARM architectures builds of PyTorch. Includes Apple M1 module: cpu CPU specific problem (e.g., perf, algorithm) module: third_party release notes: cpp release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Nicoshev @facebook-github-bot @pytorchmergebot @ZainRizvi @malfet