Convert caffe2/aten Tensors to/from c10 #14820
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D13348044 Differential Version: 65510290
This was referenced Dec 5, 2018
Closed
Differential Revision: D13348044 Differential Version: 65565562
Differential Revision: D13348044 Differential Version: 65592972
Differential Revision: D13348044 Differential Version: 65631701
Differential Revision: D13348044 Differential Version: 65642406
Differential Revision: D13348044 Differential Version: 66011184
Differential Revision: D13348044 Differential Version: 66055120
Differential Revision: D13348044 Differential Version: 66104934
Differential Revision: D13348044 Differential Version: 66142693
Differential Revision: D13348044 Differential Version: 66149122
Differential Revision: D13348044 Differential Version: 6616442
Collaborator
|
I'd actually prefer the conversion to be explicit instead of implicit for following reasons:
|
Differential Revision: D13348044 Differential Version: 66445919
This was referenced Dec 14, 2018
li-roy
reviewed
Dec 14, 2018
Contributor
li-roy
left a comment
li-roy
left a comment
There was a problem hiding this comment.
I think enforcement happens before operators like ResizeLike, and as far as I know we can't get tensors to run in a net without going through an enforcement. I do agree that this is probably a better place to check for contiguous.
dzhulgakov
reviewed
Dec 17, 2018
aten/src/ATen/core/Tensor.h
Outdated
| Tensor(const Tensor&) = default; | ||
| Tensor(Tensor&&) = default; | ||
|
|
||
| /* implicit */ Tensor(C10Tensor tensor) |
Collaborator
There was a problem hiding this comment.
don't remember on which diff I was leaving these comments - but I think conversion into at::Tensor or caffe2::Tensor should be enforcing invariants and thus they should be explicit
Contributor
Author
|
Sounds good to me, I made them explicit. |
Differential Revision: D13348044 Differential Version: 66743747
This was referenced Dec 17, 2018
Closed
Closed
ezyang
approved these changes
Jan 7, 2019
Differential Revision: D13348044 Differential Version: 68145970
Differential Revision: D13348044 Differential Version: 68260741
This was referenced Jan 9, 2019
Closed
Closed
Closed
Differential Revision: D13348044 Differential Version: 68276422
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jan 9, 2019
Summary: Pull Request resolved: pytorch/pytorch#14820 Reviewed By: dzhulgakov Differential Revision: D13348044 fbshipit-source-id: 95008e6ead3cfc478696b1c203769241d4cf6ca8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #14819 Implement c10::Tensor 💚
:black_circle: #14820 Convert caffe2/aten Tensors to/from c10 💚
:white_circle: #15195 Use C10Tensor in the dispatcher 💚
:white_circle: #15324 Fix C10_API/C10_EXPORT for op schema registration 💚
:white_circle: #15367 Update flat_hash_map 💚
:white_circle: #15199 Move LayerNorm op schema to c10 💚
:white_circle: #15243 Enable calling caffe2 LayerNorm from PyTorch and JIT 💚
:white_circle: #15312 Remove Context from c10 operator schemas 💚
:white_circle: #15316 Move files to/from c10/core and c10/util 💚
:white_circle: #15317 Clean up Half 💚
:white_circle: #15407 caffe2::Tensor::is_same() 💚
:white_circle: #15853 Move blob to c10 💛
:white_circle: #15854 Code style cleanup 💛
:white_circle: #15855 Remove some dependencies from ivalue.h to ATen 💛
:white_circle: #15856 Fix export macros 💛
Differential Revision: D13348044