Skip to content

Conversation

@tinglvv
Copy link
Collaborator

@tinglvv tinglvv commented Feb 21, 2025

follow up for https://github.com/pytorch/pytorch/pull/146265/files, dropping sm_70 as well, since "Architecture support for Maxwell, Pascal, and Volta is considered feature-complete and will be frozen in an upcoming release."

#145570

cc @ptrblck @atalman @nWEIdia

@tinglvv tinglvv requested a review from a team as a code owner February 21, 2025 08:08
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147607

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6970267 with merge base aade4fb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@tinglvv tinglvv added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Feb 21, 2025
@scraprats
Copy link

Do not remove the support. 12.8 works just fine for these capabilities. Last night I compiled llama.cpp and ollama for sm_52.

@Skylion007
Copy link
Collaborator

Do not remove the support. 12.8 works just fine for these capabilities. Last night I compiled llama.cpp and ollama for sm_52.

If we can fix the linking of large binaries for libtorch with --relink, we can keep it.

@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 25, 2025
@ptrblck
Copy link
Collaborator

ptrblck commented Mar 4, 2025

sm_70 is deprecated in CUDA 12.8 and will be removed in future CUDA releases.
If you depend on older architectures, please use PyTorch binaries built for these (e.g. with CUDA 12.6.3).

If we can fix the linking of large binaries for libtorch with --relink, we can keep it.

It's not about a linking issue, but to drop deprecated architectures.

@tinglvv
Copy link
Collaborator Author

tinglvv commented Mar 4, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased remove-sm70-cu128 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout remove-sm70-cu128 && git pull --rebase)

@tinglvv tinglvv added the topic: not user facing topic category label Mar 5, 2025
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman
Copy link
Contributor

atalman commented Mar 5, 2025

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 5, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@rowanworth
Copy link

sm_70 is deprecated in CUDA 12.8 and will be removed in future CUDA releases.

This statement seems misleading. The official NVIDIA release notes for 12.8.1 say "Architecture support for Maxwell, Pascal, and Volta is considered feature-complete and will be frozen in an upcoming release." Frozen suggests to me that CUDA will continue to work on these architectures but no more fixes/features will come in the future.

The release notes for CUDA 12.9 clarify that sm_50-sm_70 support will remain for 12.x and it will be dropped for the next major release.

(none of this means the pytorch official build for CUDA >=12.8 has to continue to support sm_50-sm_70, I'm just clarifying that CUDA itself will continue to provide that support)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants