Move TensorOptions, DefaultDtype to c10 #14746
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 4, 2018
This was referenced Dec 4, 2018
Closed
ezyang
approved these changes
Dec 6, 2018
Differential Revision: D13318644 Differential Version: 65592900
smessmer
force-pushed
the
export-D13318644
branch
from
089c46c to
d661340
Compare
smessmer
changed the title
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Dec 7, 2018
Summary: Pull Request resolved: pytorch/pytorch#14746 Reviewed By: ezyang Differential Revision: D13318644 fbshipit-source-id: b703d7dc67e75d9e9571c80d62a100c5fc4e84df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #14746 Move TensorOptions, DefaultDtype to c10 💚
:white_circle: #14747 Fix include paths for TensorOptions 💛
:white_circle: #14658 Remove TensorImpl -> context_base dependency 💚
:white_circle: #14792 Remove unused TensorImpl dependencies 💛
:white_circle: #14793 Move WrapDimMinimal to c10 💛
:white_circle: #14794 Fix include path for WrapDimMinimal.h 💛
:white_circle: #14795 Move TensorImpl to c10 (yay!) 💛
:white_circle: #14816 Fix include paths for TensorImpl.h 💛
:white_circle: #14817 Move UndefinedTensorImpl to c10 (meh) 💛
:white_circle: #14818 Fix include paths for UndefinedTensorImpl.h 💛
:white_circle: #14819 Implement c10::Tensor 💛
:white_circle: #14820 Convert caffe2/aten Tensors to/from c10 💛
Pull Request resolved: #14746
Differential Revision: D13318644