xpu: torch.xpu.get_arch_list() to return [] if xpu not compiled #147431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially discussed here: pytorch#132945 (comment) Previously `torch.xpu.get_arch_list()` got relaxed to work even if XPU device is not available. However, we overlooked the case when pytorch is not compiled with XPU support. In such a case function throws an exception. This commit adjusts this behavior and makes function return `[]` even if pytorch is not compiled with XPU support. Signed-off-by: Dmitry Rogozhkin <[email protected]>
dvrogozh
requested review from
EikanWang,
ezyang,
fmassa,
gujinghui and
soumith
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147431
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit c290b5b with merge base 525ca80 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
@pytorchbot label "topic: not user facing" |
guangyey
approved these changes
Feb 19, 2025
guangyey
added
ciflow/xpu
guangyey
requested review from
malfet
and removed request for
fmassa and
soumith
EikanWang
approved these changes
Feb 20, 2025
albanD
approved these changes
Feb 21, 2025
Collaborator
|
"The failures are unrelated to this PR." |
Collaborator
Merge startedYour change will be merged while ignoring the following 3 checks: xpu / linux-jammy-xpu-2025.0-py3.9 / test (default, 4, 4, linux.idc.xpu), trunk / linux-focal-rocm6.3-py3.10 / test (default, 1, 2, linux.rocm.gpu.2), trunk / linux-focal-rocm6.3-py3.10 / test (default, 2, 2, linux.rocm.gpu.2) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
aditew01
pushed a commit
that referenced
this pull request
Feb 28, 2025
) Initially discussed here: #132945 (comment) Previously `torch.xpu.get_arch_list()` got relaxed to work even if XPU device is not available. However, we overlooked the case when pytorch is not compiled with XPU support. In such a case function throws an exception. This commit adjusts this behavior and makes function return `[]` even if pytorch is not compiled with XPU support. CC: @EikanWang @fengyuan14 @guangyey @malfet @albanD Pull Request resolved: #147431 Approved by: https://github.com/guangyey, https://github.com/EikanWang, https://github.com/albanD
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially discussed here: #132945 (comment)
Previously
torch.xpu.get_arch_list()got relaxed to work even if XPU device is not available. However, we overlooked the case when pytorch is not compiled with XPU support. In such a case function throws an exception. This commit adjusts this behavior and makes function return[]even if pytorch is not compiled with XPU support.CC: @EikanWang @fengyuan14 @guangyey @malfet @albanD