[BE][Ez]: Apply FURB188: use str remove(pre|suf)fix#146997
Closed
Skylion007 wants to merge 2 commits intopytorch:mainfrom
Closed
[BE][Ez]: Apply FURB188: use str remove(pre|suf)fix#146997Skylion007 wants to merge 2 commits intopytorch:mainfrom
Skylion007 wants to merge 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146997
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (5 Unrelated Failures)As of commit bae4910 with merge base ce80865 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
module: dynamo
oncall: distributed
Skylion007
requested review from
albanD,
angelayi,
avikchaudhuri,
eqy,
justinchuby,
shubhambhokare1,
soulitzer,
syed-ahmed,
titaiwangms,
tugsbayasgalan,
wschin,
ydwu4 and
zhxchen17
as code owners
Skylion007
added
the
better-engineering
XuehaiPan
reviewed
Feb 12, 2025
XuehaiPan
approved these changes
Feb 12, 2025
cyyever
approved these changes
Feb 13, 2025
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge failedReason: Approvers from one of the following sets are needed:
|
Skylion007
changed the title
Skylion007
changed the title
jansel
approved these changes
Feb 13, 2025
Collaborator
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
titaiwangms
added
topic: not user facing
Collaborator
|
@Skylion007 I am switching this from release note: ONNX to not user facing to avoid the confusion from releasing docs. Feel free to change it to the right topic! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we are on 3.9, we can use this nice str builtin which is more readable and more efficient.
cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @chenyang78 @kadeng @chauhang @amjames @StrongerXi