Skip to content

[dynamo] Fix tensordict regression #146995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anijain2305 wants to merge 2 commits into from
Closed

[dynamo] Fix tensordict regression #146995

anijain2305 wants to merge 2 commits into from

Conversation

@anijain2305
Copy link
Contributor

@anijain2305 anijain2305 commented Feb 12, 2025 •
edited by pytorch-bot bot
Loading

@anijain2305 anijain2305 mentioned this pull request Feb 12, 2025
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 12, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146995

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 5 Pending, 4 Unrelated Failures

As of commit e772d44 with merge base 6105b6f (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@anijain2305 anijain2305 added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Feb 12, 2025
@anijain2305
Update on "[dynamo] Fix tensordict regression"
e772d44 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@anijain2305 anijain2305 requested a review from jansel February 12, 2025 17:50
anijain2305 added a commit that referenced this pull request Feb 12, 2025
@anijain2305
[dynamo] Fix tensordict regression
726c3df 
ghstack-source-id: f1a5e3e
Pull Request resolved: #146995
@anijain2305
Copy link
Contributor Author

anijain2305 commented Feb 12, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 12, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 12, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor / unit-test / cuda12.4-py3.10-gcc9-sm86 / test (inductor, 1, 2, linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@anijain2305
Copy link
Contributor Author

anijain2305 commented Feb 13, 2025

@pytorchbot merge -i

@anijain2305 anijain2305 mentioned this pull request Feb 13, 2025
Closed
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 13, 2025

Merge started

Your change will be merged while ignoring the following 5 checks: inductor / unit-test / linux-jammy-cpu-py3.9-gcc11-inductor / test (inductor_amx, 1, 2, linux.8xlarge.amx), inductor / unit-test / linux-jammy-cpu-py3.9-gcc11-inductor / test (inductor_avx2, 1, 2, linux.10xlarge.avx2), inductor / unit-test / cuda12.4-py3.10-gcc9-sm86 / test (inductor, 1, 2, linux.g5.4xlarge.nvidia.gpu), inductor / unit-test / cuda12.4-py3.13-gcc9-sm86 / test (inductor, 1, 2, linux.g5.4xlarge.nvidia.gpu), inductor / unit-test / cuda12.4-py3.12-gcc9-sm86 / test (inductor, 1, 2, linux.g5.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Feb 14, 2025
@anijain2305 @pytorchmergebot
[dynamo] Make SliceVariable a subclass of VariableTracker (#147046)
76f57e1 
Pull Request resolved: #147046
Approved by: https://github.com/StrongerXi
ghstack dependencies: #146819, #146995
@github-actions github-actions bot deleted the gh/anijain2305/680/head branch March 23, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel Awaiting requested review from jansel

@williamwen42 williamwen42 Awaiting requested review from williamwen42

1 more reviewer

@StrongerXi StrongerXi StrongerXi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anijain2305 @pytorchmergebot @StrongerXi