Skip to content

Conversation

@tinglvv
Copy link
Collaborator

@tinglvv tinglvv commented Feb 12, 2025

@tinglvv tinglvv requested review from a team and jeffdaily as code owners February 12, 2025 01:37
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Feb 12, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146957

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 3 Pending

As of commit 1a64bc6 with merge base f50d359 (image):
💚 Looks good so far! There are no failures yet. 💚

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

if [[ ${CUDA_VERSION:0:4} == "12.8" ]]; then
CUDNN_NAME="cudnn-linux-x86_64-9.7.1.26_cuda12-archive"
elif [[ ${CUDA_VERSION:0:4} == "12.6" ]]; then
CUDNN_NAME="cudnn-linux-x86_64-9.5.1.17_cuda12-archive"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12.6 is supported by the latest CUDNN too, why not build against there as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, issue is that the AMI testing for cuda 12.8 is in process, if we update cuda 12.6 now in this PR it will need to rebuild win AMI (it's the same AMI for various cuda versions). Let's update 12.6 cudnn next week as a follow-up.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDNN 9.6 fixes some hopper bugs for fp8 matmuls so we should update it to the latest version too.

@tinglvv
Copy link
Collaborator Author

tinglvv commented Feb 12, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 12, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

atalman pushed a commit to pytorch/test-infra that referenced this pull request Feb 13, 2025
follow up for pytorch/pytorch#146957
use 9.7.1.26 for CUDA 12.6 too to test the windows AMI

cc @atalman
@Skylion007
Copy link
Collaborator

@tinglvv Why didn't we update 12.6 at the same time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants