-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[cuDNN] cuDNN to 9.7.1.26 for CUDA 12.8 #146957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146957
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 3 PendingAs of commit 1a64bc6 with merge base f50d359 ( UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
atalman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| if [[ ${CUDA_VERSION:0:4} == "12.8" ]]; then | ||
| CUDNN_NAME="cudnn-linux-x86_64-9.7.1.26_cuda12-archive" | ||
| elif [[ ${CUDA_VERSION:0:4} == "12.6" ]]; then | ||
| CUDNN_NAME="cudnn-linux-x86_64-9.5.1.17_cuda12-archive" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
12.6 is supported by the latest CUDNN too, why not build against there as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, issue is that the AMI testing for cuda 12.8 is in process, if we update cuda 12.6 now in this PR it will need to rebuild win AMI (it's the same AMI for various cuda versions). Let's update 12.6 cudnn next week as a follow-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CUDNN 9.6 fixes some hopper bugs for fp8 matmuls so we should update it to the latest version too.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
follow up for pytorch/pytorch#146957 use 9.7.1.26 for CUDA 12.6 too to test the windows AMI cc @atalman
rebasing for pytorch#146717 Pull Request resolved: pytorch#146957 Approved by: https://github.com/Skylion007, https://github.com/eqy, https://github.com/nWEIdia, https://github.com/atalman Co-authored-by: Aaron Gokaslan <[email protected]>
rebasing for pytorch#146717 Pull Request resolved: pytorch#146957 Approved by: https://github.com/Skylion007, https://github.com/eqy, https://github.com/nWEIdia, https://github.com/atalman Co-authored-by: Aaron Gokaslan <[email protected]>
|
@tinglvv Why didn't we update 12.6 at the same time? |
rebasing for #146717
cc @atalman @malfet @eqy @ptrblck @nWEIdia