Skip to content

[dynamo][user-defined] Unify standard and non-standard __new__ codebase #146737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anijain2305 wants to merge 9 commits into from
Closed

[dynamo][user-defined] Unify standard and non-standard __new__ codebase #146737

anijain2305 wants to merge 9 commits into from

Conversation

@anijain2305
Copy link
Contributor

@anijain2305 anijain2305 commented Feb 8, 2025 •
edited
Loading

@anijain2305 anijain2305 mentioned this pull request Feb 7, 2025
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 8, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146737

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 97b36c6 with merge base 2a55311 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@anijain2305 anijain2305 mentioned this pull request Feb 7, 2025
Closed
@anijain2305 anijain2305 added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category keep-going Don't stop on first failure, keep running tests until the end labels Feb 8, 2025
@anijain2305
Update on "[dynamo][user-defined] Unify standard and non-standard __n…
a4b0b6b 
…ew__ codebase"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@anijain2305
Update on "[dynamo][user-defined] Unify standard and non-standard __n…
ac35dc5 
…ew__ codebase"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@anijain2305
Update on "[dynamo][user-defined] Unify standard and non-standard __n…
3998947 
…ew__ codebase"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@anijain2305
Update on "[dynamo][user-defined] Unify standard and non-standard __n…
8462609 
…ew__ codebase"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@anijain2305
Update on "[dynamo][user-defined] Unify standard and non-standard __n…
ecc5504 
…ew__ codebase"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@anijain2305
Update on "[dynamo][user-defined] Unify standard and non-standard __n…
e5a69ac 
…ew__ codebase"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@anijain2305
Update on "[dynamo][user-defined] Unify standard and non-standard __n…
676e212 
…ew__ codebase"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@anijain2305
Update on "[dynamo][user-defined] Unify standard and non-standard __n…
97b36c6 
…ew__ codebase"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@anijain2305 anijain2305 requested a review from jansel February 10, 2025 03:50
@anijain2305
Copy link
Contributor Author

anijain2305 commented Feb 10, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 10, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@anijain2305 anijain2305 mentioned this pull request Feb 10, 2025
Closed
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 10, 2025

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@anijain2305
Copy link
Contributor Author

anijain2305 commented Feb 10, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 10, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@anijain2305
Copy link
Contributor Author

anijain2305 commented Feb 10, 2025

@pytorchbot merge -f "stuck CI"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 10, 2025

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 10, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

majing921201 pushed a commit to majing921201/pytorch that referenced this pull request Mar 4, 2025
@anijain2305 @majing921201
[dynamo][user-defined] Unify standard and non-standard __new__ codeba…
8f466b1 
…se (pytorch#146737)

Pull Request resolved: pytorch#146737
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#146677
@github-actions github-actions bot deleted the gh/anijain2305/676/head branch March 13, 2025 02:10
jurgen-paul pushed a commit to jurgen-paul/pytorch.git.file that referenced this pull request Mar 19, 2025
@anijain2305
[dynamo][user-defined] Unify standard and non-standard __new__ codebase
dd57187 
ghstack-source-id: 5975eb6
Pull Request resolved: pytorch/pytorch#146737
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request keep-going Don't stop on first failure, keep running tests until the end Merged module: dynamo topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anijain2305 @pytorchmergebot @jansel