Skip to content

[BE][cuDNN] cuDNN to 9.7.1.26 for CUDA 12.8 #146717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eqy wants to merge 1 commit into from
Closed

[BE][cuDNN] cuDNN to 9.7.1.26 for CUDA 12.8 #146717

eqy wants to merge 1 commit into from
+14 −12

Conversation

@eqy
Copy link
Collaborator

@eqy eqy commented Feb 7, 2025 •
edited by pytorch-bot bot
Loading

cuDNN 9.7.1 is out now and is expected to be the longer-lived branch with more potential backports vs. 9.7.0

CC @nWEIdia @tinglvv

cc @malfet @seemethere @csarofeen @ptrblck @xwang233

@eqy eqy added module: build Build system issues module: cudnn Related to torch.backends.cudnn, and CuDNN support open source topic: not user facing topic category topic: build labels Feb 7, 2025
@eqy eqy requested review from a team and jeffdaily as code owners February 7, 2025 19:25
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146717

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 2 Unrelated Failures

As of commit be24249 with merge base fc5913b (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cpuhrsch cpuhrsch requested a review from drisspg February 8, 2025 01:39
@cpuhrsch cpuhrsch added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 8, 2025
@Skylion007 Skylion007 added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Feb 9, 2025
Skylion007
Skylion007 approved these changes Feb 9, 2025
View reviewed changes
Copy link
Collaborator

@Skylion007 Skylion007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good assuming the binaries are uploaded to the S3 nightly bucket

@tinglvv
Copy link
Collaborator

tinglvv commented Feb 11, 2025 •
edited
Loading

Looks like 9.7.1.26 wheels (https://pypi.org/project/nvidia-cudnn-cu12/#files) need to be uploaded to https://download.pytorch.org/whl/nightly/cu128/nvidia-cudnn-cu12/

@tinglvv
Copy link
Collaborator

tinglvv commented Feb 11, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 11, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 11, 2025

Successfully rebased cudnn971 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout cudnn971 && git pull --rebase)

@tinglvv tinglvv mentioned this pull request Feb 11, 2025
Merged
atalman pushed a commit to pytorch/test-infra that referenced this pull request Feb 11, 2025
@tinglvv
update cudnn 9.7.1.26 for cuda 12.8 windows (#6280)
17278f3 
pytorch/pytorch#145570

follow up to pytorch/pytorch#146717

cc @atalman
@tinglvv tinglvv mentioned this pull request Feb 12, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Feb 12, 2025
@tinglvv @Skylion007 @pytorchmergebot
[cuDNN] cuDNN to 9.7.1.26 for CUDA 12.8 (#146957)
0344bf8 
rebasing for #146717

Pull Request resolved: #146957
Approved by: https://github.com/Skylion007, https://github.com/eqy, https://github.com/nWEIdia, https://github.com/atalman

Co-authored-by: Aaron Gokaslan <[email protected]>
@Skylion007
Copy link
Collaborator

Skylion007 commented Feb 14, 2025

We should also update CUDNN for 12.6, right?

Raymo111 pushed a commit that referenced this pull request Feb 20, 2025
@tinglvv @Skylion007 @Raymo111
[cuDNN] cuDNN to 9.7.1.26 for CUDA 12.8 (#146957)
119b096 
rebasing for #146717

Pull Request resolved: #146957
Approved by: https://github.com/Skylion007, https://github.com/eqy, https://github.com/nWEIdia, https://github.com/atalman

Co-authored-by: Aaron Gokaslan <[email protected]>
majing921201 pushed a commit to majing921201/pytorch that referenced this pull request Mar 4, 2025
@tinglvv @Skylion007 @majing921201
[cuDNN] cuDNN to 9.7.1.26 for CUDA 12.8 (pytorch#146957)
8207847 
rebasing for pytorch#146717

Pull Request resolved: pytorch#146957
Approved by: https://github.com/Skylion007, https://github.com/eqy, https://github.com/nWEIdia, https://github.com/atalman

Co-authored-by: Aaron Gokaslan <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Apr 15, 2025
@github-actions github-actions bot closed this May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@malfet malfet malfet approved these changes

@drisspg drisspg drisspg approved these changes

@tinglvv tinglvv tinglvv approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

Assignees

No one assigned

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR module: build Build system issues module: cudnn Related to torch.backends.cudnn, and CuDNN support open source Stale topic: build topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@eqy @tinglvv @pytorchmergebot @Skylion007 @malfet @drisspg @cpuhrsch