Skip to content

windows Magma and cuda build for cu128 #146653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tinglvv wants to merge 4 commits into from
Closed

windows Magma and cuda build for cu128 #146653

tinglvv wants to merge 4 commits into from

Conversation

@tinglvv
Copy link
Collaborator

@tinglvv tinglvv commented Feb 6, 2025 •
edited
Loading

#145570

removing .ci/pytorch/windows/internal/cuda_install.bat as it is a duplicate with .github/scripts/windows/cuda_install.bat. The later one is the one in use - https://github.com/pytorch/pytorch/pull/146653/files#diff-613791f266f2f7b81148ca8f447b0cd6c6544f824f5f46a78a2794006c78957bR8

cc @atalman @ptrblck @nWEIdia

@tinglvv tinglvv requested a review from a team as a code owner February 6, 2025 23:33
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 6, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146653

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 181 Pending

As of commit 126d019 with merge base 99dd846 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Feb 6, 2025
@tinglvv tinglvv mentioned this pull request Feb 6, 2025
Closed
26 tasks
atalman
atalman approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman
Copy link
Contributor

atalman commented Feb 7, 2025

@pytorchmergebot merge -f "All the jobs are green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 7, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman
Copy link
Contributor

atalman commented Feb 7, 2025

@pytorchmergebot revert -c nosignal -m "Broke nightly builds"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 7, 2025

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 7, 2025

@tinglvv your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Feb 7, 2025
@pytorchmergebot
Revert "windows Magma build for cu128 (#146653)"
f17109b 
This reverts commit 9e27d36.

Reverted #146653 on behalf of https://github.com/atalman due to Broke nightly builds ([comment](#146653 (comment)))
@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Feb 7, 2025
@atalman atalman added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label Feb 7, 2025
@atalman
Copy link
Contributor

atalman commented Feb 10, 2025

@pytorchmergebot merge -f "All the jobs are green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 10, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 10, 2025

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 10, 2025

@tinglvv your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Feb 10, 2025
@pytorchmergebot
Revert "windows Magma build for cu128 (#146653)"
b826135 
This reverts commit d0e70c4.

Reverted #146653 on behalf of https://github.com/jeanschmidt due to Seems to have broken some windows tests, reverting to see if it gets green ([comment](#146653 (comment)))
@jeanschmidt jeanschmidt added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 10, 2025
@atalman
Copy link
Contributor

atalman commented Feb 10, 2025

Looks like failure maybe not related:

1a64:15a8 @ 03109843 - LdrpFindKnownDll - ENTER: DLL name: bcrypt.dll
1a64:15a8 @ 03109843 - LdrpFindKnownDll - RETURN: Status: 0x00000000
1a64:15a8 @ 03109843 - LdrpMinimalMapModule - ENTER: DLL name: C:\Windows\System32\bcrypt.dll
ModLoad: 00007ffc`780c0000 00007ffc`780e6000   C:\Windows\System32\bcrypt.dll
1a64:15a8 @ 03109843 - LdrpMinimalMapModule - RETURN: Status: 0x00000000
1a64:15a8 @ 03109843 - LdrpFindDllActivationContext - INFO: Probing for the manifest of DLL "C:\Windows\System32\bcrypt.dll" failed with status 0xc000008a

@jeanschmidt
Copy link
Contributor

jeanschmidt commented Feb 10, 2025

Seems unrelated:

https://github.com/pytorch/pytorch/actions/runs/13246927668/job/36977751039

@jeanschmidt
Copy link
Contributor

jeanschmidt commented Feb 10, 2025

@pytorchbot merge -f "re-merge, signals parsed"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 10, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman atalman mentioned this pull request Feb 11, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Feb 11, 2025
@atalman @pytorchmergebot
Fix var CUDA_PATH_V128 in cuda128.bat file (#146906)
d5d3bdb 
Followup after: #146653
This should fix upcoming CUDA 12.8 windows builds.
Issue found during pytorch-canary Windows AMI test.

Pull Request resolved: #146906
Approved by: https://github.com/malfet, https://github.com/tinglvv
Ryo-not-rio pushed a commit to Ryo-not-rio/pytorch that referenced this pull request Feb 24, 2025
@atalman @Ryo-not-rio
Fix var CUDA_PATH_V128 in cuda128.bat file (pytorch#146906)
1c51f0b 
Followup after: pytorch#146653
This should fix upcoming CUDA 12.8 windows builds.
Issue found during pytorch-canary Windows AMI test.

Pull Request resolved: pytorch#146906
Approved by: https://github.com/malfet, https://github.com/tinglvv
majing921201 pushed a commit to majing921201/pytorch that referenced this pull request Mar 4, 2025
@atalman @majing921201
Fix var CUDA_PATH_V128 in cuda128.bat file (pytorch#146906)
7827372 
Followup after: pytorch#146653
This should fix upcoming CUDA 12.8 windows builds.
Issue found during pytorch-canary Windows AMI test.

Pull Request resolved: pytorch#146906
Approved by: https://github.com/malfet, https://github.com/tinglvv
@tinglvv tinglvv changed the title windows Magma build for cu128 windows Magma and cuda build for cu128 May 6, 2025
@atalman atalman mentioned this pull request Jun 12, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Jun 12, 2025
@atalman @pytorchmergebot
[CD] Windows Magma build 12.9 and cuda scripts (#155799)
0d3d84d 
Scripts needed to build Magma and CUDA on windows
Same as #146653
Pull Request resolved: #155799
Approved by: https://github.com/jeanschmidt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: releng release notes category Reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tinglvv @atalman @pytorchmergebot @jeanschmidt @pytorchbot