Remove TensorImpl -> context_base dependency #14658
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D13283495 Differential Version: 65035202
Differential Revision: D13283492 Differential Version: 65035196
Differential Revision: D13283493 Differential Version: 65035197
Differential Revision: D13283496 Differential Version: 65035200
Differential Revision: D13283494 Differential Version: 65035199
Differential Revision: D13283497 Differential Version: 65035198
Differential Revision: D13285370 Differential Version: 65047127
Differential Revision: D13288655 Differential Version: 65070335
This was referenced Dec 1, 2018
Closed
Closed
Differential Revision: D13283495 Differential Version: 65268356
Differential Revision: D13283492 Differential Version: 65268357
Differential Revision: D13283493 Differential Version: 65268352
Differential Revision: D13283496 Differential Version: 65268353
Differential Revision: D13283494 Differential Version: 65268354
Differential Revision: D13283497 Differential Version: 65268358
Differential Revision: D13285370 Differential Version: 65268360
Differential Revision: D13288655 Differential Version: 65268355
Contributor
|
@li-roy can you please review this PR? |
dzhulgakov
approved these changes
Dec 4, 2018
Differential Revision: D13288655 Differential Version: 65309524
This was referenced Dec 4, 2018
li-roy
approved these changes
Dec 4, 2018
Differential Revision: D13288655 Differential Version: 65334577
This was referenced Dec 5, 2018
Closed
Differential Revision: D13288655 Differential Version: 65565559
Differential Revision: D13288655 Differential Version: 65592968
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Dec 8, 2018
Summary: Pull Request resolved: pytorch/pytorch#14658 Remove this dependency by moving at::CopyBytes to c10. The implementations for at::CopyBytes will have to live in aten/caffe2 for now because they're not unified for CUDA yet. They'll be moved into c10/backend/xxx later. Reviewed By: dzhulgakov Differential Revision: D13288655 fbshipit-source-id: 1c92379345308b3cd39a402779d7b7999613fc0d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #14746 Move TensorOptions, DefaultDtype to c10 💚
:white_circle: #14747 Fix include paths for TensorOptions 💛
:black_circle: #14658 Remove TensorImpl -> context_base dependency 💚
:white_circle: #14792 Remove unused TensorImpl dependencies 💛
:white_circle: #14793 Move WrapDimMinimal to c10 💛
:white_circle: #14794 Fix include path for WrapDimMinimal.h 💛
:white_circle: #14795 Move TensorImpl to c10 (yay!) 💛
:white_circle: #14816 Fix include paths for TensorImpl.h 💛
:white_circle: #14817 Move UndefinedTensorImpl to c10 (meh) 💛
:white_circle: #14818 Fix include paths for UndefinedTensorImpl.h 💛
:white_circle: #14819 Implement c10::Tensor 💛
:white_circle: #14820 Convert caffe2/aten Tensors to/from c10 💛
Remove this dependency by moving at::CopyBytes to c10.
The implementations for at::CopyBytes will have to live in aten/caffe2 for now because they're not unified for CUDA yet.
They'll be moved into c10/backend/xxx later.
Differential Revision: D13288655