[MPS] linalg solve implementation #146531
Conversation
Isalia20
requested review from
IvanYashchuk,
kulinseth,
lezcano,
malfet and
nikitaved
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146531
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ No Failures, 49 PendingAs of commit 08b8bf6 with merge base fd0cd6a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Attention! native_functions.yaml was changedIf you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info. Caused by: |
malfet
added
topic: improvements
| run_lu_factor_ex_test(32, 10, 10, check_errors=False) | ||
| run_lu_factor_ex_test(32, 2, 2, 2, 2, 10, 10, check_errors=True) | ||
|
|
||
| def test_linalg_solve(self): |
There was a problem hiding this comment.
Just curious, is this test really necessary, as OpInfo tests presumably already covers that?
|
@pytorchbot merge -f "Lint + MPS are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
4 participants
Fixes #98222