Skip to content

[MPS] Fix regression in con-contig bitwise ops #146085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malfet wants to merge 1 commit into from
Closed

[MPS] Fix regression in con-contig bitwise ops #146085

malfet wants to merge 1 commit into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Jan 30, 2025 •
edited
Loading

Caused by #128393 that change semantic of needsGather, which resulted in silent correctness errors on MacOS-15+ if output tensor is non-contiguous

Fixes #145203

@malfet
[MPS] Fix regression in con-contig bitwise ops
ae6c1e5 
Caused by #128393 that change semantic of `needsGather`, which resulted in silent correctness errors on MacOS-15+ if output tensor is non-contiguous

Fixes #145203
@malfet malfet requested a review from kulinseth as a code owner January 30, 2025 21:43
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 30, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146085

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 36 Pending

As of commit ae6c1e5 with merge base 08ff11e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Jan 30, 2025
@malfet malfet requested review from dcci and manuelcandales January 30, 2025 21:43
@malfet malfet added the topic: bug fixes topic category label Jan 30, 2025
@dcci dcci self-requested a review January 30, 2025 22:09
@malfet
Copy link
Contributor Author

malfet commented Jan 30, 2025

@pytorchbot merge -f "Lint + MPS are green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 30, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the malfet/mps-fix-bitiwse-ops branch March 2, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcci dcci dcci approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

@manuelcandales manuelcandales Awaiting requested review from manuelcandales

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged release notes: mps Release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Indexed ^= (XOR in-place) operation doesn't work as expected on MPS backend

4 participants

@malfet @pytorchmergebot @dcci