[ONNX] Create deprecation warning on dynamo_export #146003

justinchuby · 2025-01-30T02:32:32Z

Deprecation of torch.onnx.dynamo_export:

torch/onnx/_internal/_exporter_legacy.py: Added deprecation warnings to the OnnxRegistry, ExportOptions, ONNXRuntimeOptions, and dynamo_export functions, indicating that torch.onnx.dynamo_export is deprecated since version 2.6.0 and should be replaced with torch.onnx.export(..., dynamo=True). [1] [2] [3] [4]

This PR also removed the **_ kwarg on onnx.export such that users get an error when they supply an unexpected augument.

Updated to emit deprecation warning because it is more appropriate: https://docs.python.org/3/library/exceptions.html#DeprecationWarning

pytorch-bot · 2025-01-30T02:32:36Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146003

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit 65d9b41 with merge base 32bb6f8 ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

linux-binary-manywheel / manywheel-py3_9-cuda12_4-test / test (gh) (similar failure)
Process completed with exit code 1.
linux-binary-manywheel / manywheel-py3_9-cuda12_6-test / test (gh) (similar failure)
Process completed with exit code 1.
trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-13) (gh) (detected as infra flaky with no log or failing log classifier)

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

linux-binary-manywheel / manywheel-py3_9-cuda11_8-test / test (gh) (trunk failure)
Process completed with exit code 1.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

justinchuby · 2025-01-30T17:27:07Z

@pytorchbot merge

pytorchmergebot · 2025-01-30T17:29:46Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-01-30T17:40:52Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / lintrunner-noclang / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

justinchuby · 2025-01-30T17:48:59Z

@pytorchbot merge

pytorchmergebot · 2025-01-30T17:50:44Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-01-30T18:12:26Z

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable)

Details for Dev Infra team

Raised by workflow job

justinchuby · 2025-01-30T18:22:40Z

@pytorchbot merge -i

pytorchmergebot · 2025-01-30T18:24:21Z

Merge started

Your change will be merged while ignoring the following 5 checks: pull / linux-focal-py3.13-clang10 / test (default, 2, 5, lf.linux.4xlarge), pull / linux-focal-py3.13-clang10 / test (crossref, 2, 2, lf.linux.2xlarge), pull / linux-jammy-py3.9-gcc11 / test (default, 2, 5, lf.linux.2xlarge), pull / linux-focal-py3.9-clang10 / test (default, 2, 5, lf.linux.4xlarge), trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-01-30T18:24:50Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

justinchuby · 2025-01-30T19:09:11Z

@pytorchbot merge

…dels_e2e.py (#146095) With [the deprecation of torch.onnx.dynamo_export](#146003), this PR turns the torch.export related tests toward torch.onn.export(..., dynamo=True), and places it in test_small_models_e2e.py NOTE: test_exported_program_as_input_from_file and test_onnx_program_supports_retraced_graph are not kept, because they are more of testing whether exported program stays the same after save/load and retrace. However, in torch.onnx.export(..., dynamo=True), we focus more on the export of from nn.Module to ONNX proto. Pull Request resolved: #146095 Approved by: https://github.com/justinchuby

atalman · 2025-02-03T17:14:54Z

@pytorchmergebot revert -c nosignal -m "Broke internally"

pytorchmergebot · 2025-02-03T17:17:10Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

This reverts commit e6c39d3. Reverted #146003 on behalf of https://github.com/atalman due to Broke internally ([comment](#146003 (comment)))

pytorchmergebot · 2025-02-03T17:17:18Z

@justinchuby your PR has been successfully reverted.

justinchuby · 2025-02-03T17:27:44Z

@atalman sorry what's broken?

justinchuby · 2025-02-03T17:28:32Z

torch/onnx/_internal/exporter/_compat.py

    dump_exported_program: bool = False,
    artifacts_dir: str | os.PathLike = ".",
    fallback: bool = False,
-    **_,


Is it this line?

atalman · 2025-02-03T18:15:32Z

@justinchuby deprecation error is causing unit tests to fail, as the pytorch code still has references to the old torch.onnx.dynamo_export: https://github.com/pytorch/pytorch/blob/main/benchmarks/dynamo/common.py#L2047

justinchuby · 2025-02-03T18:35:54Z

I see. Is this the only reference? If we remove this reference will it succeed?

justinchuby · 2025-02-03T19:10:19Z

#146325

atalman · 2025-02-03T19:17:17Z

hi @justinchuby once #146325 lands please rebase this PR, we should rebase and reimport this PR internally so we can run tests

ONNX exporter experiments in benchmark is obsolete and unmaintained. This PR removes it to unblock #146003 Pull Request resolved: #146325 Approved by: https://github.com/titaiwangms

Summary: ONNX exporter experiments in benchmark is obsolete and unmaintained. This PR removes it to unblock pytorch/pytorch#146003 X-link: pytorch/pytorch#146325 Approved by: https://github.com/titaiwangms Reviewed By: ZainRizvi Differential Revision: D69115633 fbshipit-source-id: 20f264458f38d1dafde100970f07b6622e5b3d6e

justinchuby · 2025-02-04T18:06:27Z

Replaced by #146425

Deprecation of `torch.onnx.dynamo_export`: * [`torch/onnx/_internal/_exporter_legacy.py`](diffhunk://#diff-4d1eb96fe68ea904dcd1f8211318b9ff882dbfe4c3cb725ffc164b6c5a58b74cR83-R86): Added deprecation warnings to the `OnnxRegistry`, `ExportOptions`, `ONNXRuntimeOptions`, and `dynamo_export` functions, indicating that `torch.onnx.dynamo_export` is deprecated since version 2.6.0 and should be replaced with `torch.onnx.export(..., dynamo=True)`. [[1]](diffhunk://#diff-4d1eb96fe68ea904dcd1f8211318b9ff882dbfe4c3cb725ffc164b6c5a58b74cR83-R86) [[2]](diffhunk://#diff-4d1eb96fe68ea904dcd1f8211318b9ff882dbfe4c3cb725ffc164b6c5a58b74cR231-R234) [[3]](diffhunk://#diff-4d1eb96fe68ea904dcd1f8211318b9ff882dbfe4c3cb725ffc164b6c5a58b74cR442-R445) [[4]](diffhunk://#diff-4d1eb96fe68ea904dcd1f8211318b9ff882dbfe4c3cb725ffc164b6c5a58b74cR700-R703) This PR also removed the `**_` kwarg on onnx.export such that users get an error when they supply an unexpected augument. Updated to emit deprecation warning because it is more appropriate: https://docs.python.org/3/library/exceptions.html#DeprecationWarning Pull Request resolved: pytorch#146003 Approved by: https://github.com/titaiwangms

…dels_e2e.py (pytorch#146095) With [the deprecation of torch.onnx.dynamo_export](pytorch#146003), this PR turns the torch.export related tests toward torch.onn.export(..., dynamo=True), and places it in test_small_models_e2e.py NOTE: test_exported_program_as_input_from_file and test_onnx_program_supports_retraced_graph are not kept, because they are more of testing whether exported program stays the same after save/load and retrace. However, in torch.onnx.export(..., dynamo=True), we focus more on the export of from nn.Module to ONNX proto. Pull Request resolved: pytorch#146095 Approved by: https://github.com/justinchuby

…46003)" This reverts commit e6c39d3. Reverted pytorch#146003 on behalf of https://github.com/atalman due to Broke internally ([comment](pytorch#146003 (comment)))

ONNX exporter experiments in benchmark is obsolete and unmaintained. This PR removes it to unblock pytorch#146003 Pull Request resolved: pytorch#146325 Approved by: https://github.com/titaiwangms

Reland #146003 Deprecation of `torch.onnx.dynamo_export`: * [`torch/onnx/_internal/_exporter_legacy.py`]: Added deprecation warnings to the `OnnxRegistry`, `ExportOptions`, `ONNXRuntimeOptions`, and `dynamo_export` functions, indicating that `torch.onnx.dynamo_export` is deprecated since version 2.6.0 and should be replaced with `torch.onnx.export(..., dynamo=True)`. Pull Request resolved: #146425 Approved by: https://github.com/titaiwangms, https://github.com/atalman

Reland pytorch#146003 Deprecation of `torch.onnx.dynamo_export`: * [`torch/onnx/_internal/_exporter_legacy.py`]: Added deprecation warnings to the `OnnxRegistry`, `ExportOptions`, `ONNXRuntimeOptions`, and `dynamo_export` functions, indicating that `torch.onnx.dynamo_export` is deprecated since version 2.6.0 and should be replaced with `torch.onnx.export(..., dynamo=True)`. Pull Request resolved: pytorch#146425 Approved by: https://github.com/titaiwangms, https://github.com/atalman

[ONNX] Create deprecation warning on dynamo_export

8565ece

justinchuby requested review from shubhambhokare1, titaiwangms and wschin as code owners January 30, 2025 02:32

pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Jan 30, 2025

justinchuby added module: onnx Related to torch.onnx topic: deprecation topic category labels Jan 30, 2025

DeprecationWarning

3b69eec

pytorchbot added the open source label Jan 30, 2025

fix test

05427ba

titaiwangms approved these changes Jan 30, 2025

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 30, 2025

pytorchmergebot added the merging label Jan 30, 2025

pytorchmergebot removed the merging label Jan 30, 2025

line

ccaffe7

pytorchmergebot added the merging label Jan 30, 2025

pytorchmergebot removed the merging label Jan 30, 2025

pytorchmergebot added the merging label Jan 30, 2025

fix

65d9b41

titaiwangms mentioned this pull request Jan 30, 2025

[ONNX] Migrate test_torch_export_with_onnxruntime.py to test_small_models_e2e.py #146095

Closed

pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Feb 3, 2025

pytorchmergebot reopened this Feb 3, 2025

justinchuby commented Feb 3, 2025

View reviewed changes

justinchuby added this to the 2.7.0 milestone Feb 3, 2025

justinchuby mentioned this pull request Feb 3, 2025

[benchmark] Remove ONNX #146325

Closed

justinchuby mentioned this pull request Feb 4, 2025

[ONNX] Create deprecation warning on dynamo_export #146425

Closed

justinchuby closed this Feb 4, 2025

justinchuby removed this from the 2.7.0 milestone Feb 7, 2025

[ONNX] Create deprecation warning on dynamo_export #146003

[ONNX] Create deprecation warning on dynamo_export #146003

Uh oh!

Conversation

justinchuby commented Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146003

✅ You can merge normally! (4 Unrelated Failures)

Uh oh!

justinchuby commented Jan 30, 2025

Uh oh!

pytorchmergebot commented Jan 30, 2025

Merge started

Uh oh!

pytorchmergebot commented Jan 30, 2025

Merge failed

Uh oh!

justinchuby commented Jan 30, 2025

Uh oh!

pytorchmergebot commented Jan 30, 2025

Merge started

Uh oh!

pytorchmergebot commented Jan 30, 2025

Merge failed

Uh oh!

justinchuby commented Jan 30, 2025

Uh oh!

pytorchmergebot commented Jan 30, 2025

Merge started

Uh oh!

pytorchmergebot commented Jan 30, 2025

Uh oh!

justinchuby commented Jan 30, 2025

Uh oh!

atalman commented Feb 3, 2025

Uh oh!

pytorchmergebot commented Feb 3, 2025

Uh oh!

pytorchmergebot commented Feb 3, 2025

Uh oh!

justinchuby commented Feb 3, 2025

Uh oh!

justinchuby Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

atalman commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

justinchuby commented Feb 3, 2025

Uh oh!

justinchuby commented Feb 3, 2025

Uh oh!

atalman commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

justinchuby commented Feb 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

justinchuby commented Jan 30, 2025 •

edited

Loading

pytorch-bot bot commented Jan 30, 2025 •

edited

Loading

atalman commented Feb 3, 2025 •

edited

Loading

atalman commented Feb 3, 2025 •

edited

Loading