Skip to content

Add CUDA 12.8 libtorch image #145789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tinglvv wants to merge 1 commit into from
Closed

Add CUDA 12.8 libtorch image #145789

tinglvv wants to merge 1 commit into from

Conversation

@tinglvv
Copy link
Collaborator

@tinglvv tinglvv commented Jan 27, 2025

#145570

Builds 12.8 libtorch docker/deprecate 12.1 meanwhile

cc @atalman @ptrblck @nWEIdia

@tinglvv tinglvv requested review from a team and jeffdaily as code owners January 27, 2025 22:51
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 27, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145789

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 8196cbd with merge base bfaf76b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jan 27, 2025
@tinglvv
Copy link
Collaborator Author

tinglvv commented Jan 27, 2025 •
edited
Loading

build failure
denied: User: arn:aws:sts::391835788720:assumed-role/ghci-lf-github-action-runners-runner-role/i-0617a89444392328b is not authorized to perform: ecr:InitiateLayerUpload on resource: arn:aws:ecr:us-east-1:308535385114:repository/pytorch/libtorch-cxx11-builder-cuda12.8 because no resource-based policy allows the ecr:InitiateLayerUpload action

@atalman , could you help with libtorch-cxx11-builder-cuda12.8 ecr creation? Thanks!

This was referenced Jan 27, 2025
Closed
Closed
@johnnynunez
Copy link
Contributor

johnnynunez commented Jan 28, 2025 •
edited
Loading

cc @eqy

atalman
atalman approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tinglvv
Copy link
Collaborator Author

tinglvv commented Jan 28, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 28, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 28, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 22:12 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 22:12 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 22:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

@nWEIdia nWEIdia nWEIdia approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tinglvv @johnnynunez @pytorchmergebot @atalman @nWEIdia @pytorchbot