Skip to content

Set USE_CUFILE=1 by default and add pypi package to binary build matrix #145748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mikaylagawarecki wants to merge 19 commits into from
Closed

Set USE_CUFILE=1 by default and add pypi package to binary build matrix #145748

mikaylagawarecki wants to merge 19 commits into from

Conversation

@mikaylagawarecki
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki commented Jan 27, 2025 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 27, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145748

Note: Links to docs will display an error until the docs builds have been completed.

❌ 10 New Failures, 1 Pending, 2 Unrelated Failures

As of commit fe806a1 with merge base b60f630 (image):

NEW FAILURES - The following jobs have failed:

  • linux-binary-manywheel / manywheel-py3_10-rocm6_2_4-test (gh)
    Action 'https://api.github.com/repos/pytorch/pytorch/tarball/86b52f420986e8d74176934aba57a9f1ee4a9629' download has timed out. Error: The request was canceled due to the configured HttpClient.Timeout of 100 seconds elapsing.
  • linux-binary-manywheel / manywheel-py3_10-rocm6_3-test (gh)
    Action 'https://api.github.com/repos/pytorch/pytorch/tarball/3d604b17d91b928c850ded83b2ec25ea066bb3f6' download has timed out. Error: The request was canceled due to the configured HttpClient.Timeout of 100 seconds elapsing.
  • linux-binary-manywheel / manywheel-py3_11-rocm6_2_4-test (gh)
    Unable to download artifact(s): Unable to download and extract artifact: Artifact download failed after 5 retries.
  • linux-binary-manywheel / manywheel-py3_11-rocm6_3-test (gh)
    Action 'https://api.github.com/repos/pytorch/pytorch/tarball/3d604b17d91b928c850ded83b2ec25ea066bb3f6' download has timed out. Error: The request was canceled due to the configured HttpClient.Timeout of 100 seconds elapsing.
  • linux-binary-manywheel / manywheel-py3_12-rocm6_2_4-test (gh)
    Action 'https://api.github.com/repos/pytorch/pytorch/tarball/3d604b17d91b928c850ded83b2ec25ea066bb3f6' download has timed out. Error: The request was canceled due to the configured HttpClient.Timeout of 100 seconds elapsing.
  • linux-binary-manywheel / manywheel-py3_12-rocm6_3-test (gh)
    Action 'https://api.github.com/repos/pytorch/pytorch/tarball/86b52f420986e8d74176934aba57a9f1ee4a9629' download has timed out. Error: The request was canceled due to the configured HttpClient.Timeout of 100 seconds elapsing.
  • linux-binary-manywheel / manywheel-py3_13-rocm6_2_4-test (gh)
    Action 'https://api.github.com/repos/pytorch/pytorch/tarball/3d604b17d91b928c850ded83b2ec25ea066bb3f6' download has timed out. Error: The request was canceled due to the configured HttpClient.Timeout of 100 seconds elapsing.
  • linux-binary-manywheel / manywheel-py3_13-rocm6_3-test (gh)
    Action 'https://api.github.com/repos/pytorch/pytorch/tarball/3d604b17d91b928c850ded83b2ec25ea066bb3f6' download has timed out. Error: The request was canceled due to the configured HttpClient.Timeout of 100 seconds elapsing.
  • linux-binary-manywheel / manywheel-py3_13-xpu-test (gh)
    Unable to download artifact(s): Unable to download and extract artifact: Artifact download failed after 5 retries.
  • linux-binary-manywheel / manywheel-py3_9-rocm6_3-test (gh)
    Action 'https://api.github.com/repos/pytorch/pytorch/tarball/3d604b17d91b928c850ded83b2ec25ea066bb3f6' download has timed out. Error: The request was canceled due to the configured HttpClient.Timeout of 100 seconds elapsing.

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jan 27, 2025
@mikaylagawarecki mikaylagawarecki added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 27, 2025
mikaylagawarecki added a commit that referenced this pull request Jan 27, 2025
@mikaylagawarecki
Set USE_CUFILE=1 by default and add pypi package to binary build matrix
d6df2c0 
ghstack-source-id: 391c1dd
Pull Request resolved: #145748
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 27, 2025 20:11 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 27, 2025 20:11 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 27, 2025 20:11 Inactive
Skylion007
Skylion007 reviewed Jan 27, 2025
View reviewed changes
mikaylagawarecki
mikaylagawarecki commented Jan 28, 2025
View reviewed changes
mikaylagawarecki added a commit that referenced this pull request Jan 30, 2025
@mikaylagawarecki
Set USE_CUFILE=1 by default and add pypi package to binary build matrix
76d3413 
ghstack-source-id: 7d4efe5
Pull Request resolved: #145748
@mikaylagawarecki mikaylagawarecki marked this pull request as ready for review January 31, 2025 15:48
@mikaylagawarecki mikaylagawarecki requested a review from a team as a code owner January 31, 2025 15:48
@atalman atalman added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label Jan 31, 2025
atalman
atalman reviewed Jan 31, 2025
View reviewed changes
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 11, 2025

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@mikaylagawarecki
Copy link
Contributor Author

mikaylagawarecki commented Feb 11, 2025

@pytorchbot merge -f

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 11, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot merge: error: argument -f/--force: expected one argument

usage: @pytorchbot merge [-f MESSAGE | -i] [-ic] [-r [{viable/strict,main}]]

Try @pytorchbot --help for more info.

@mikaylagawarecki
Copy link
Contributor Author

mikaylagawarecki commented Feb 11, 2025

@pytorchbot merge -f "rocm flaky + rocm distributed queued overnight"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 11, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@mikaylagawarecki mikaylagawarecki mentioned this pull request Feb 13, 2025
Closed
mikaylagawarecki added a commit that referenced this pull request Feb 13, 2025
@mikaylagawarecki
Update on "Make torch.cuda.gds APIs public"
e69386d 
Follow up to #145748




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this pull request Feb 13, 2025
@mikaylagawarecki
Update on "Make torch.cuda.gds APIs public"
15f8c79 
Follow up to #145748




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this pull request Feb 13, 2025
@mikaylagawarecki
Update on "Make torch.cuda.gds APIs public"
bd3809b 
Follow up to #145748




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this pull request Feb 13, 2025
@mikaylagawarecki
Update on "Make torch.cuda.gds APIs public"
0334c3c 
Follow up to #145748 that turned USE_CUFILE on for CUDA 12.6 and 12.8 binaries




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this pull request Feb 13, 2025
@mikaylagawarecki
Update base for Update on "Make torch.cuda.gds APIs public"
253bf67 
Follow up to #145748 that turned USE_CUFILE on for CUDA 12.6 and 12.8 binaries




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this pull request Feb 13, 2025
@mikaylagawarecki
Update on "Make torch.cuda.gds APIs public"
72c5e4f 
Follow up to #145748 that turned USE_CUFILE on for CUDA 12.6 and 12.8 binaries




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this pull request Feb 13, 2025
@mikaylagawarecki
Update base for Update on "Make torch.cuda.gds APIs public"
0a11b0f 
Follow up to #145748 that turned USE_CUFILE on for CUDA 12.6 and 12.8 binaries




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this pull request Feb 13, 2025
@mikaylagawarecki
Update on "Make torch.cuda.gds APIs public"
fa05d4e 
Follow up to #145748 that turned USE_CUFILE on for CUDA 12.6 and 12.8 binaries




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this pull request Feb 14, 2025
@mikaylagawarecki
Update base for Update on "Make torch.cuda.gds APIs public"
791ea3b 
Follow up to #145748 that turned USE_CUFILE on for CUDA 12.6 and 12.8 binaries




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this pull request Feb 14, 2025
@mikaylagawarecki
Update on "Make torch.cuda.gds APIs public"
5768d7f 
Follow up to #145748 that turned USE_CUFILE on for CUDA 12.6 and 12.8 binaries




[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Feb 14, 2025
@mikaylagawarecki @pytorchmergebot
Make torch.cuda.gds APIs public (#147120)
e8fbc86 
Follow up to #145748 that turned USE_CUFILE on for CUDA 12.6 and 12.8 binaries

Pull Request resolved: #147120
Approved by: https://github.com/albanD
desai0007 pushed a commit to desai0007/test-repo-pytorch that referenced this pull request Feb 26, 2025
@mikaylagawarecki
Set USE_CUFILE=1 by default and add pypi package to binary build matrix
8a436db 
ghstack-source-id: accb2c7
Pull Request resolved: pytorch/pytorch#145748
@atalman atalman mentioned this pull request Feb 27, 2025
Closed
@github-actions github-actions bot deleted the gh/mikaylagawarecki/311/head branch March 14, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

@atalman atalman atalman approved these changes

Assignees

No one assigned

Labels

ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mikaylagawarecki @pytorchmergebot @Skylion007 @atalman